Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configtelemetry, exporter/debug, exporter/logging] Stop using configtelemetry.Level for verbosity #9528

Closed
mx-psi opened this issue Feb 8, 2024 · 6 comments
Labels
area:config exporter/debug Issues related to the Debug exporter exporter/logging Logging exporter related issues on hold release:required-for-ga Must be resolved before GA release

Comments

@mx-psi
Copy link
Member

mx-psi commented Feb 8, 2024

Per #9510 (comment), we want to remove configtelemetry in favor of views. We would still have to use a type in debug and logging, so we should make a copy of this type to use in these exporters instead of using the package that eventually will be deprecated.

@mx-psi mx-psi added release:required-for-ga Must be resolved before GA release area:config exporter/logging Logging exporter related issues exporter/debug Issues related to the Debug exporter labels Feb 8, 2024
@AkhigbeEromo
Copy link
Contributor

Hello @mx-psi would like to work on this issue.
Just to clarify what i am to do.

Deprecate configtelemetry.Level.

If this is done what other function will replace it

@mx-psi
Copy link
Member Author

mx-psi commented Apr 1, 2024

Hey @AkhigbeEromo, the idea for this issue would be to create a new enum type with the same fields that gets used in the debug and logging exporter configuration.

We don't want to deprecate configtelemetry.Level for this task (we need to do more work for that!), just stop using it on these exporters' configuration.

@AkhigbeEromo
Copy link
Contributor

Been trying to work on this task😂,
Getting stuck in some places
Let me ask
Can I use this approach to solve this problem:
`
type VerbosityLevel int32

const (
VerbosityLevelNone VerbosityLevel = iota - 1
VerbosityLevelBasic
VerbosityLevelNormal
VerbosityLevelDetailed

verbosityLevelNoneStr     = "None"
verbosityLevelBasicStr    = "Basic"
verbosityLevelNormalStr   = "Normal"
verbosityLevelDetailedStr = "Detailed"

)
`
Can I use this method to declare a new struct that will store the different verbosity levels

Or is there something better I can apply @mx-psi

@mx-psi
Copy link
Member Author

mx-psi commented Apr 16, 2024

@AkhigbeEromo Apologies for the delay. Based on #9510 (comment), I am going to put this issue on hold until #9510 is resolved, since we may end up not wanting to do this

@mx-psi mx-psi added the on hold label Apr 16, 2024
@AkhigbeEromo
Copy link
Contributor

Okay understood @mx-psi

@mx-psi mx-psi moved this to Blocked in Collector: v1 Apr 18, 2024
@mx-psi
Copy link
Member Author

mx-psi commented Jul 17, 2024

I am going to close this as wontfix

@mx-psi mx-psi closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2024
@github-project-automation github-project-automation bot moved this from Blocked to Done in Collector: v1 Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:config exporter/debug Issues related to the Debug exporter exporter/logging Logging exporter related issues on hold release:required-for-ga Must be resolved before GA release
Projects
Archived in project
Development

No branches or pull requests

2 participants