Distribute internal metrics across different levels #9767
Conversation
dmitryax
force-pushed
the
move-internal-metrics-to-normal
branch
2 times, most recently
from
7fc0d50 to
d2068ac
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9767 +/- ##
==========================================
- Coverage 91.79% 91.73% -0.06%
==========================================
Files 358 358
Lines 16576 16584 +8
==========================================
- Hits 15216 15214 -2
- Misses 1037 1042 +5
- Partials 323 328 +5 ☔ View full report in Codecov by Sentry. |
dmitryax
force-pushed
the
move-internal-metrics-to-normal
branch
from
d2068ac to
2218e9b
Compare
There was a problem hiding this comment.
How does this interact with #9510 (comment) ?
I think we should make a decision on whether to remove Metrics Level and if so what's our plan until we remove it
|
I'm ok with having other configs for that, like views. AFAIU, this isn't possible even with |
dmitryax
changed the title
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
processor/batchprocessor/metrics.go
Outdated
| meter metric.Meter | ||
| ) | ||
|
|
||
| // BatchProcessor metrics are not subject to the same level of filtering as other components. |
There was a problem hiding this comment.
Isn't this true for all components? If the default is normal, aren't all metrics (other than instrumentation library metrics) emitted?
There was a problem hiding this comment.
Isn't this true for all components?
Yes, it's true for all components. With this comment, I wanted to say that the batch processor is the only component in core emitting metrics (with the normal level). It's probably confusing. Let me update it
If the default is normal, aren't all metrics (other than instrumentation library metrics) emitted?
Right
dmitryax
force-pushed
the
move-internal-metrics-to-normal
branch
from
2218e9b to
2357865
Compare
The internal metrics levels are updated along with reported metrics:
- The default level is changed from `basic` to `normal`, which can be overridden with `service::telmetry::metrics::level` configuration.
- Batch processor metrics are updated to be reported starting from `normal` level:
- `processor_batch_batch_send_size`
- `processor_batch_metadata_cardinality`
- `processor_batch_timeout_trigger_send`
- `processor_batch_size_trigger_send`
- GRPC/HTTP server and client metrics are updated to be reported starting from `detailed` level:
- http.client.* metrics
- http.server.* metrics
- rpc.server.* metrics
- rpc.client.* metrics
dmitryax
force-pushed
the
move-internal-metrics-to-normal
branch
from
2357865 to
ee3f4bc
Compare
Description:
This change distributes the reported internal metrics across available levels and updates the level set by default:
The default level is changed from
basictonormal, which can be overridden withservice::telmetry::metrics::levelconfiguration.The following batch processor metrics are updated to be reported starting from
normallevel instead ofbasiclevel:processor_batch_batch_send_sizeprocessor_batch_metadata_cardinalityprocessor_batch_timeout_trigger_sendprocessor_batch_size_trigger_senddetailedlevel:http.client.*metricshttp.server.*metricsrpc.server.*metricsrpc.client.*metricsLink to tracking Issue: #7890