-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Update windows tests component groups #32518
[chore] Update windows tests component groups #32518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad there's no way at all to dig into the history of the code to figure out who to blame 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another PR is in flight that changes the exporter groups. Depending on which one is merged first, the other will need modified. I'm adding a comment there to update accordingly.
I've submitted #32520 to resolve the failing SQL Server unit tests on Windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that more tests need to be skipped.
@@ -45,8 +51,7 @@ jobs: | |||
GOMEMLIMIT: 2GiB | |||
steps: | |||
- uses: actions/checkout@v4 | |||
- if: matrix.group == 'receiver-0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove the conditional? Is it needed for something other than receiver-0
group?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it is needed for the iis receiver, which changed to group 1, showing how the condition is fragile. I removed it so that in the future if the groups change again we wont have to worry about updating this condition. That does mean that all the groups get IIS installed. Since the tests don't run that often I thought that trade off was worth it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It adds something like 50s to 1m30s to each Windows unit test run I tend to see as waste, but, overall I think you are right: this extra time and compute seems acceptable in exchange for the consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as soon as any pending test skips are added
Co-authored-by: Curtis Robert <[email protected]>
Co-authored-by: Curtis Robert <[email protected]>
Description:
Someone, and we may never know who, forgot to update the windows test groups when they created #30901
Fixes #32508