Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double the number of exporter build-and-test groups #32496

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Double the number of exporter build-and-test groups #32496

merged 6 commits into from
Apr 23, 2024

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Apr 17, 2024

Description: Double the number of exporter test groups so that new tests can be added, e.g., the new tests in #31996.

Testing: These changes were applied in #31996 and they resolved a timeout.

@jmacd jmacd requested review from a team and atoulme April 17, 2024 20:53
@jmacd jmacd added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 17, 2024
@songy23 songy23 added the ci-cd CI, CD, testing, build issues label Apr 17, 2024
crobert-1
crobert-1 approved these changes Apr 17, 2024
View reviewed changes
Makefile Show resolved Hide resolved
@crobert-1
Copy link
Member

Failing test is frequency of #27295, I've added it as frequency there.

songy23
songy23 reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update .github/workflows/build-and-test-windows.yml as well?

#32510 for context. cc @mx-psi

@crobert-1 crobert-1 mentioned this pull request Apr 18, 2024
Merged
crobert-1
crobert-1 requested changes Apr 18, 2024
View reviewed changes
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized you'll also need to update build-and-test-windows.yml with the new exporter groups.

@jmacd
Copy link
Contributor Author

jmacd commented Apr 18, 2024

Oh! The windows build-and-test appears out-of-date prior to my change--apparently was skipping some receiver tests.
See feb5ba2

@crobert-1
Copy link
Member

crobert-1 commented Apr 18, 2024 •
edited
Loading

Oh! The windows build-and-test appears out-of-date prior to my change--apparently was skipping some receiver tests. See feb5ba2

You're right, we're fixing it in #32518 which is what made me remember this would need updated too. 👍

If possible, maybe only add the new groups to the Windows tests, and let the other PR add the rest? That way the changelog will be a bit more clear going forward.

@jmacd jmacd mentioned this pull request Apr 18, 2024
Merged
@jmacd
Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…
f4a5d7e 
…tor-contrib into jmacd/double_exporter_groups
crobert-1
crobert-1 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the extra changes!

@mx-psi mx-psi added the Run Windows Enable running windows test on a PR label Apr 22, 2024
@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Apr 22, 2024
@jmacd
Copy link
Contributor Author

jmacd commented Apr 22, 2024 

=== Errors
multiple definitions of TestMain

@crobert-1
Copy link
Member 

=== Errors
multiple definitions of TestMain

Should be fixed by #32603. Hopefully another rebase should fix it.

@mx-psi mx-psi merged commit 1401157 into open-telemetry:main Apr 23, 2024
184 of 185 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 23, 2024
codeboten pushed a commit that referenced this pull request May 1, 2024
@jmacd
Double the number of processor build-and-test targets (#32526)
36ffd33 
Description: Double the number of processor test groups so that new
tests can be added, e.g., the new tests in

#31946

Testing: These changes were applied in
#31946
and they appeared to help with spurious test timeouts.

Similar to
#32496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

@crobert-1 crobert-1 crobert-1 approved these changes

@dashpole dashpole dashpole approved these changes

@atoulme atoulme Awaiting requested review from atoulme

Assignees

@dashpole dashpole

Labels
ci-cd CI, CD, testing, build issues ready to merge Code review completed; ready to merge by maintainers Run Windows Enable running windows test on a PR Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.100.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jmacd @crobert-1 @dashpole @songy23 @mx-psi