Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[.github] Add receiver-2 and receiver-3 groups to matrix for Windows unit tests #32510

Closed
wants to merge 1 commit into from
Closed

[.github] Add receiver-2 and receiver-3 groups to matrix for Windows unit tests #32510

wants to merge 1 commit into from

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Apr 18, 2024 •
edited
Loading

Description:

We missed adding these on #30901, causing #32508

Link to tracking Issue: Fixes #32508

@mx-psi mx-psi added Skip Changelog PRs that do not require a CHANGELOG.md entry Run Windows Enable running windows test on a PR labels Apr 18, 2024
@mx-psi
Copy link
Member Author

mx-psi commented Apr 18, 2024

cc @TylerHelmuth is there anything else we need to add on the Windows tests to make it run on all components?

@songy23 songy23 added the ci-cd CI, CD, testing, build issues label Apr 18, 2024
songy23
songy23 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@songy23 songy23 mentioned this pull request Apr 18, 2024
Merged
@crobert-1
Copy link
Member

Closing in favor of #32518 👍

@crobert-1 crobert-1 closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

Assignees
No one assigned
Labels
ci-cd CI, CD, testing, build issues Run Windows Enable running windows test on a PR Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[receiver/windowsperfcounters] Unit tests are not running on CI
3 participants
@mx-psi @crobert-1 @songy23