[pkg/stanza] Hash fingerprints #31317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/configschema
djaglowski
force-pushed
the
pkg-stanza-hash-fingerprints
branch
2 times, most recently
from
661d39f to
9cc2614
Compare
djaglowski
force-pushed
the
pkg-stanza-hash-fingerprints
branch
2 times, most recently
from
520fd63 to
869976b
Compare
djaglowski
force-pushed
the
pkg-stanza-hash-fingerprints
branch
from
869976b to
9b23404
Compare
djaglowski
added a commit
that referenced
this pull request
Feb 28, 2024
Depends on #31251 This is in preparation for adding additional fields to the fingerprint struct. The goal is to write the same data to storage while ensuring consistency between the fields of the struct. This problem does not present until there is a second field in the struct, but this PR prepares for that problem without adding the new field. See #31317 for additional detail.
djaglowski
force-pushed
the
pkg-stanza-hash-fingerprints
branch
from
9b23404 to
f9f7a3a
Compare
djaglowski
force-pushed
the
pkg-stanza-hash-fingerprints
branch
from
f9f7a3a to
e282966
Compare
djaglowski
removed
exporter/datadog
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…ry#31346) Depends on open-telemetry#31251 This is in preparation for adding additional fields to the fingerprint struct. The goal is to write the same data to storage while ensuring consistency between the fields of the struct. This problem does not present until there is a second field in the struct, but this PR prepares for that problem without adding the new field. See open-telemetry#31317 for additional detail.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
Now that #31516 is merged, I will revisit whether this actually improves performance. |
|
Unfortunately, at least by this benchmark, the change does not improve performance. In fact it appears to degrade performance when working with many files. It's certainly possible the additional changes would yield a better result but I have spent quite some time on this without any benefit so will close the PR and associated issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #29617
Replaces #29691
Hashes fingerprints in order to make comparisons more efficient. The hash value is stored on the fingerprint struct but does not need to be saved to storage as it can be restored based on the bytes.