[chore][pkg/stanza] Make fingerprint.FirstBytes private #31346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/configschema
github-actions
bot
requested review from
atoulme,
dineshg13,
dmitryax,
liustanley,
mackjmr,
mx-psi and
songy23
djaglowski
force-pushed
the
pkg-stanza-fingerprint-news
branch
from
59c59ab to
fc85b0e
Compare
djaglowski
force-pushed
the
pkg-stanza-fingerprint-news
branch
from
fc85b0e to
ebbec28
Compare
songy23
reviewed
Feb 28, 2024
songy23
approved these changes
Feb 28, 2024
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…ry#31346) Depends on open-telemetry#31251 This is in preparation for adding additional fields to the fingerprint struct. The goal is to write the same data to storage while ensuring consistency between the fields of the struct. This problem does not present until there is a second field in the struct, but this PR prepares for that problem without adding the new field. See open-telemetry#31317 for additional detail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #31251
This is in preparation for adding additional fields to the fingerprint struct. The goal is to write the same data to storage while ensuring consistency between the fields of the struct. This problem does not present until there is a second field in the struct, but this PR prepares for that problem without adding the new field. See #31317 for additional detail.