-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/stanza/fileconsumer] Reduce noise in benchmark #31516
Merged
djaglowski
merged 2 commits into
open-telemetry:main
from
djaglowski:pkg-stanza-fileconsumer-bench-update
Mar 28, 2024
Merged
[pkg/stanza/fileconsumer] Reduce noise in benchmark #31516
djaglowski
merged 2 commits into
open-telemetry:main
from
djaglowski:pkg-stanza-fileconsumer-bench-update
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18d1d5d
to
2764c42
Compare
2764c42
to
af235c9
Compare
af235c9
to
38e5a03
Compare
crobert-1
reviewed
Mar 7, 2024
38e5a03
to
03d2a4f
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
I think this is ready for another review @crobert-1 |
crobert-1
reviewed
Mar 27, 2024
03d2a4f
to
a71d7cc
Compare
a71d7cc
to
5a9555e
Compare
crobert-1
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the end-to-end benchmark in
pkg/stanza/fileconsumer
.The primary goal is to surface a more accurate representation of performance within the benchmark. Several factors were leading to artificial delays which I believe may have drowned out actual impacts. Three significant sources of noise were mitigated:
The overall result is a substantially clearer CPU profile and a slightly clearer memory profile.
CPU Profile Before
![image](https://private-user-images.githubusercontent.com/5255616/310222120-a8bcd396-8c4a-4dcb-8c0b-0a3cbc852a86.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzQ0ODk0NzEsIm5iZiI6MTczNDQ4OTE3MSwicGF0aCI6Ii81MjU1NjE2LzMxMDIyMjEyMC1hOGJjZDM5Ni04YzRhLTRkY2ItOGMwYi0wYTNjYmM4NTJhODYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MTIxOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDEyMThUMDIzMjUxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YzFiOTFmN2Y5ZDhhNWVkM2U5NzBiMTAzNjkzNTI4ZjczZDVjMzUzNTFjM2E1MjlmYTM5YjBmYmRhNjY4NWRlOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.VPwnV--KrrzW-2RxwOgOedt-eunkUUFMrmrszu4GwO8)
CPU Profile After
![image](https://private-user-images.githubusercontent.com/5255616/312210624-14ee9a7b-af2f-4df5-a8a5-10cb8830c9b6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzQ0ODk0NzEsIm5iZiI6MTczNDQ4OTE3MSwicGF0aCI6Ii81MjU1NjE2LzMxMjIxMDYyNC0xNGVlOWE3Yi1hZjJmLTRkZjUtYThhNS0xMGNiODgzMGM5YjYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MTIxOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDEyMThUMDIzMjUxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTc1NDVhZmRkZGVkNmRkMzMzZjFjMmM1NzgxZDc0OGRiZjJmYWE4N2YzODE4ZjEyYjJjNTMxMzE5MDNkYzczMCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.PH3xGECKlCEPT67kzIlTWiDXKHSWm4_tOX5EsJAPScw)
Memory Profile Before
![image](https://private-user-images.githubusercontent.com/5255616/310223533-86604420-754b-43f2-a143-39f60faed9d8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzQ0ODk0NzEsIm5iZiI6MTczNDQ4OTE3MSwicGF0aCI6Ii81MjU1NjE2LzMxMDIyMzUzMy04NjYwNDQyMC03NTRiLTQzZjItYTE0My0zOWY2MGZhZWQ5ZDgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MTIxOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDEyMThUMDIzMjUxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MGUwYzlhNmJiNWEzZjBiM2ZhNDllNTdkYjYzMDVmMGY2ZDhjNGI3NTA1NTRkMmU0ZjIxMWI3ZjcxNTY2ZmEzYSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.xPxBzZKNWbuzpFdjuXMwCYuKGglxjqJfWaL8n6mUT1A)
Memory Profile After
![image](https://private-user-images.githubusercontent.com/5255616/312210422-6752be62-2d73-4f9d-bcea-aa5835cce601.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzQ0ODk0NzEsIm5iZiI6MTczNDQ4OTE3MSwicGF0aCI6Ii81MjU1NjE2LzMxMjIxMDQyMi02NzUyYmU2Mi0yZDczLTRmOWQtYmNlYS1hYTU4MzVjY2U2MDEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MTIxOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDEyMThUMDIzMjUxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MWIwZmM4MTUwMDhhMmIyNGZjNjI2MjgyZTI0MTE2MGU4MTUyYmQ0NTE0ZTZjNDNiZTBhNDg2YTZkNTVhMTliNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.zM_w3VpEhENa80wmzLyOEBRkGLFdQwshZvP0LGioFxM)
Additionally, this adds a new benchmark to cover a scenario with many (100) files. Finally, it reduces the time to run the benchmark from ~30s to ~20s.