Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remote sampling endpoint from the Jaeger receiver #6633

Closed
Tracked by #6510
jpkrohling opened this issue Dec 8, 2021 · 3 comments
Closed
Tracked by #6510

Remove remote sampling endpoint from the Jaeger receiver #6633

jpkrohling opened this issue Dec 8, 2021 · 3 comments
Assignees
@frzifus
Labels
comp:jaeger Jaeger related issues comp: receiver Receiver

Comments

@jpkrohling
Copy link
Member

No description provided.

@jpkrohling jpkrohling mentioned this issue Dec 8, 2021
Closed
5 tasks
@jpkrohling jpkrohling self-assigned this Dec 8, 2021
@jpkrohling jpkrohling added comp: receiver Receiver comp:jaeger Jaeger related issues labels Dec 8, 2021
@frzifus
Copy link
Member

frzifus commented Jul 30, 2022

hey @jpkrohling, can i work on that?

@jpkrohling jpkrohling assigned frzifus and unassigned jpkrohling Aug 1, 2022
@jpkrohling
Copy link
Member Author

It's yours

@frzifus frzifus mentioned this issue Aug 3, 2022
Closed
@frzifus frzifus mentioned this issue Aug 18, 2022
Merged
@frzifus frzifus mentioned this issue Sep 16, 2022
Merged
@frzifus
Copy link
Member

frzifus commented Sep 21, 2022

@jpkrohling can we close it?

@pavankrish123 pavankrish123 mentioned this issue Nov 29, 2022
Closed
povilasv referenced this issue in coralogix/opentelemetry-collector-contrib Dec 19, 2022
@pavankrish123
Fix nil panic from otlp exporter (#6633)
67866ce 
* fix nil panic from otlp exporter.

* fix nil panic from otlp exporter.

* fix nil panic from otlp exporter.
@rfratto rfratto mentioned this issue Feb 4, 2023
Closed
@ptodev ptodev mentioned this issue Jul 11, 2023
Merged
jpkrohling added a commit that referenced this issue Aug 28, 2023
@ptodev @jpkrohling
[receiver/jaeger] Removing remote sampling configuration code (#24186)
0c12aa3 
Most remote sampling code is already removed from the jaeger receiver
via #6633, but the configuration is still there. It is unused and should
be removed.

The only reason I can think of for retaining it is so that old
configuration files don't stop the Collector from running. However,
given that this is a no-op, I think it would be better to have an error
and let the customers reconfigure their collectors. Here, I'm assuming
that configuring a struct which doesn't exist will indeed raise an
error.

There is no changelog entry since the change is mostly an implementation
detail.

---------

Co-authored-by: Juraci Paixão Kröhling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frzifus frzifus

Labels
comp:jaeger Jaeger related issues comp: receiver Receiver
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpkrohling @frzifus