[receiver/jaegerreceiver] Add remote sampling deprecation warning #13408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frzifus
commented
Aug 18, 2022
receiver/jaegerreceiver/factory.go
Outdated
| func logSamplingDeprecation(logger *zap.Logger) { | ||
| once.Do(func() { | ||
| logger.Warn( | ||
| "Jaeger remote sampling support is deprecated and will be removed in future versions. Use the jaegerremotesampling extension instead.", |
There was a problem hiding this comment.
Should we point to a specific version here?
There was a problem hiding this comment.
I assume a feature flag is not needed? [documentation]
There was a problem hiding this comment.
Should we point to a specific version here?
Yes, that makes sense.
I assume a feature flag is not needed?
I also don't see the need for a feature flag here.
frzifus
force-pushed
the
deprecate_jaeger_remote_sampling_on_receiver_#6633
branch
from
760b72a to
d16ce33
Compare
frzifus
force-pushed
the
deprecate_jaeger_remote_sampling_on_receiver_#6633
branch
2 times, most recently
from
2400acf to
ac29939
Compare
jpkrohling
approved these changes
Aug 22, 2022
receiver/jaegerreceiver/factory.go
Outdated
| func logSamplingDeprecation(logger *zap.Logger) { | ||
| once.Do(func() { | ||
| logger.Warn( | ||
| "Jaeger remote sampling support is deprecated and will be removed in release v0.60.0. Use the jaegerremotesampling extension instead.", |
There was a problem hiding this comment.
Perhaps v0.61.0? We have 0.58.0 out already, this message would start appearing only at 0.59.0.
Signed-off-by: Benedikt Bongartz <[email protected]>
frzifus
force-pushed
the
deprecate_jaeger_remote_sampling_on_receiver_#6633
branch
from
ac29939 to
828ee49
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Benedikt Bongartz [email protected]
Description:
with #6632 and #6694 remote sampling is offered as extention. This pr adds a deprecation warning to the remote sampling endpoint provided in the receiver.
Link to tracking Issue: #6633 (part of)
Testing:
Documentation: