Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing/Jaeger: No longer listening on remote sampling port 5778 #2911

Closed
simonswine opened this issue Feb 2, 2023 · 2 comments
Closed

Tracing/Jaeger: No longer listening on remote sampling port 5778 #2911

simonswine opened this issue Feb 2, 2023 · 2 comments
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Comments

@simonswine
Copy link
Contributor

simonswine commented Feb 2, 2023

I have hit a problem with using remote sampling through Grafana Agent.

This is roughly my config (single replica stateful set of Grafana Agent):

kind: ConfigMap
apiVersion: v1
data:
  agent.yaml: |
    server:
        log_level: debug
    traces:
        configs:
            - name: kubernetes-traces
              receivers:
                jaeger:
                    protocols:
                        grpc: null
                        thrift_binary: null
                        thrift_compact: null
                        thrift_http: null
                    remote_sampling:
                        strategy_file: /etc/agent/strategy.json
                        tls:
                            insecure: true
              remote_write:
                - endpoint: tempo.monitoring.svc.cluster.local:4317
                  insecure: true
                  retry_on_failure:
                    enabled: true
              scrape_configs:
                - bearer_token_file: /var/run/secrets/kubernetes.io/serviceaccount/token
                  job_name: kubernetes-pods
                  kubernetes_sd_configs:
                    - role: pod
                  relabel_configs:
                    - action: replace
                      source_labels:
                        - __meta_kubernetes_namespace
                      target_label: namespace
                    - action: replace
                      source_labels:
                        - __meta_kubernetes_pod_name
                      target_label: pod
                    - action: replace
                      source_labels:
                        - __meta_kubernetes_pod_container_name
                      target_label: container
                  tls_config:
                    ca_file: /var/run/secrets/kubernetes.io/serviceaccount/ca.crt
                    insecure_skip_verify: false
  strategy.json: '{"default_strategy":{"param":1,"type":"probabilistic"}}'
[...]

When using Grafana Agent v0.28.1 (or earlier), everything works as expected and the remote sampling is listening on port 5778. Once I am upgrading to anything later than v0.29.0, Grafana Agent no longer listens to port 5778.

@rfratto
Copy link
Member

rfratto commented Feb 4, 2023

We updated our OpenTelemetry Collector dependency to v0.61.0 in the v0.29 release. It looks like the remote sampling endpoint was removed entirely in that release: https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.61.0

jaegerreceiver: Remove remote sampling endpoint from the Jaeger receiver (open-telemetry/opentelemetry-collector-contrib#6633)

@tpaschalis
Copy link
Member

I'm closing this as we can't do much about the upstream dependency. Thanks for bringing this to our attention though.

@github-project-automation github-project-automation bot moved this from Todo to Done in Grafana Agent (Public) Feb 28, 2023
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
No open projects
Development

No branches or pull requests

3 participants