Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhance feed layout responsiveness #1538

Closed
wants to merge 19 commits into from

Conversation

RitaDee
Copy link
Contributor

@RitaDee RitaDee commented Aug 10, 2023

Description

This pull request addresses the responsiveness of the feed layout to ensure a consistent and optimal user experience across different devices and screen sizes.

#1490 (review)

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Screen.Recording.2023-08-07.at.16.53.22.mov

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit a3e6192
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/64d76b11b8f1bd000889330c
😎 Deploy Preview https://deploy-preview-1538--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for oss-insights ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a3e6192
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/64d76b11cc31f900070efd71
😎 Deploy Preview https://deploy-preview-1538--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RitaDee RitaDee changed the title Feed page fix: enhance feed layout responsiveness Aug 10, 2023
@RitaDee RitaDee marked this pull request as ready for review August 10, 2023 16:57
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@bdougie bdougie added the high-priority Work on these issues first label Aug 11, 2023
@bdougie
Copy link
Member

bdougie commented Aug 11, 2023

  1. This adds CHANGELOG changes.
  2. The sticky side bars on the highlight pages are not in this PR.

Production

Rewatch GIF Recording - 2023-08-11 at 4 13 10 PM

This PR

Rewatch GIF Recording - 2023-08-11 at 4 14 20 PM

@bdougie bdougie added requested changes and removed high-priority Work on these issues first labels Aug 11, 2023
Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are open errors in this pr

@bdougie bdougie added the merge conflicts Needs merge conflict resolved label Aug 12, 2023
pages/feed/index.tsx Outdated Show resolved Hide resolved
Co-authored-by: ( Nechiforel David-Samuel ) NsdHSO  <[email protected]>
@RitaDee
Copy link
Contributor Author

RitaDee commented Aug 12, 2023

@bdougie, I am curious to know if there is a reason why the CHANGELOG.md file is not placed in a .gitignore file.

IMHO, adding files like CHANGELOG.md to the .gitignore file can help prevent unintentional commits of such files, which are often auto-generated or don't need to be tracked within the repository history.

I would appreciate it if you could provide some insight into this matter.

@bdougie
Copy link
Member

bdougie commented Aug 12, 2023

@bdougie, I am curious to know if there is a reason why the CHANGELOG.md file is not placed in a .gitignore file.

IMHO, adding files like CHANGELOG.md to the .gitignore file can help prevent unintentional commits of such files, which are often auto-generated or don't need to be tracked within the repository history.

I would appreciate it if you could provide some insight into this matter.

The Changelog is automated and needs to be stored in.git. TBH other contributors have had issues with it, but from pairing with you there is a specific step you include causing this issue. I believe it is specific to how you handle merge conflicts.

Whether we need the changelog in addition to the release notes is debatable, but I think that is the wrong focus here. My suggestion is focusing on what happens after commit and merge conflicts are resolved.

We have docs on this subject here: https://docs.opensauced.pizza/technical/resolve-merge-conflicts/

@RitaDee
Copy link
Contributor Author

RitaDee commented Aug 12, 2023

@bdougie, I am curious to know if there is a reason why the CHANGELOG.md file is not placed in a .gitignore file.
IMHO, adding files like CHANGELOG.md to the .gitignore file can help prevent unintentional commits of such files, which are often auto-generated or don't need to be tracked within the repository history.
I would appreciate it if you could provide some insight into this matter.

The Changelog is automated and needs to be stored in.git. TBH other contributors have had issues with it, but from pairing with you there is a specific step you include causing this issue. I believe it is specific to how you handle merge conflicts.

Whether we need the changelog in addition to the release notes is debatable, but I think that is the wrong focus here. My suggestion is focusing on what happens after commit and merge conflicts are resolved.

We have docs on this subject here: https://docs.opensauced.pizza/technical/resolve-merge-conflicts/

The link you provided to the documentation on resolving merge conflicts is incredibly helpful, and I'll make sure to thoroughly review it to better align my approach.

@dev-phantom
Copy link
Contributor

@RitaDee can you please add what this PR fixed to the related document in the PR template
This help to auto close the issue(s) related when this PR is merged
You can check this for more info about it
#1538 (review)

@RitaDee
Copy link
Contributor Author

RitaDee commented Aug 14, 2023

Due to the challenge of resolving the merge conflict, I am closing this PR in favour of #1553.

@RitaDee RitaDee closed this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflicts Needs merge conflict resolved requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants