-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enhance feed layout responsiveness #1538
Conversation
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are open errors in this pr
Co-authored-by: ( Nechiforel David-Samuel ) NsdHSO <[email protected]>
@bdougie, I am curious to know if there is a reason why the CHANGELOG.md file is not placed in a .gitignore file. IMHO, adding files like CHANGELOG.md to the .gitignore file can help prevent unintentional commits of such files, which are often auto-generated or don't need to be tracked within the repository history. I would appreciate it if you could provide some insight into this matter. |
The Changelog is automated and needs to be stored in.git. TBH other contributors have had issues with it, but from pairing with you there is a specific step you include causing this issue. I believe it is specific to how you handle merge conflicts. Whether we need the changelog in addition to the release notes is debatable, but I think that is the wrong focus here. My suggestion is focusing on what happens after commit and merge conflicts are resolved. We have docs on this subject here: https://docs.opensauced.pizza/technical/resolve-merge-conflicts/ |
The link you provided to the documentation on resolving merge conflicts is incredibly helpful, and I'll make sure to thoroughly review it to better align my approach. |
@RitaDee can you please add what this PR fixed to the |
Due to the challenge of resolving the merge conflict, I am closing this PR in favour of #1553. |
Description
This pull request addresses the responsiveness of the feed layout to ensure a consistent and optimal user experience across different devices and screen sizes.
#1490 (review)
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Screen.Recording.2023-08-07.at.16.53.22.mov
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?