fix: enhance feed layout responsiveness #1516
Conversation
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
brandonroberts
added
merge conflicts
|
@RitaDee |
|
@brandonroberts, I have resolved the conflict. Thank you, @bdougie for the lint error fix. |
|
bug: Long names in top contributors mess up spacing on small screens. I noticed a weird side effect. I did see this get reported elsewhere. OK to have it addressed on another PR My suggestion is to add truncation when the width is adjusted.
|
Ha, this had been noted already and it was the next issue @RitaDee planned on raising, thank you for pointing that out again. |
|
Thanks for jumping on this @RitaDee |
brandonroberts
changed the title
brandonroberts
changed the title
brandonroberts
force-pushed
the
fix-regression
branch
from
62eea2c to
f12f335
Compare
|
@brandonroberts, I will fix it. |
|
@brandonroberts, I have fixed the conflict. |
|
I am seeing nothing on mobile currently |
|
@RitaDee that last merge broke the UI according to the PR preview. Will you take a look? |
|
@brandonroberts I will take a look at it. |
|
@brandonroberts, I have this fix on a new branch. Here is the link: I will close this PR. |
Description
#1490 (review)
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Screen.Recording.2023-08-07.at.16.53.22.mov
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?