Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Profile header is squashed due to new margins #1543

Closed
1 of 2 tasks
bdougie opened this issue Aug 11, 2023 · 6 comments · Fixed by #1553
Closed
1 of 2 tasks

Bug: Profile header is squashed due to new margins #1543

bdougie opened this issue Aug 11, 2023 · 6 comments · Fixed by #1553
Labels
🐛 bug Something isn't working high-priority Work on these issues first released on @beta released

Comments

@bdougie
Copy link
Member

bdougie commented Aug 11, 2023 •
edited
Loading

Describe the bug

Screen Shot 2023-08-10 at 11 15 54 PM

Steps to reproduce

View a profile full screen on the laptop.

Browsers

Chrome

Additional context (Is this in dev or production?)

This fix needs to not break any other page.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@bdougie bdougie added 🐛 bug Something isn't working 👀 needs triage labels Aug 11, 2023
@bdougie
Copy link
Member Author

bdougie commented Aug 11, 2023

Another place broken is card profiles.

https://insights.opensauced.pizza/user/SimonHoiberg/card

Screen Shot 2023-08-11 at 11 39 42 AM

Can you assist @open-sauced/triage team in discovering a fix?

@takanome-dev
Copy link
Contributor

takanome-dev commented Aug 11, 2023 •
edited
Loading

The pr #1490 broke the profile page because the feed page is using the layout wrapper of the profile page. So when Rita fixed the feed page responsiveness, it actually broke the profile page.

We should probably have layout wrapper for the feed.

Will try to find out more about the card page

edit: #1538 will fix the profile issue 😃

@a0m0rajab
Copy link
Contributor

a0m0rajab commented Aug 11, 2023 •
edited
Loading

Just a note here to prevent such behaviour in the future and be sure that we will not have any issues we might need to have snapshot tests. I opened an issue for that. (Note, can't link the issue since I am on mobile, the UX is a bit different)

Thanks takanome for your comment, it's really useful.

@babblebey
Copy link
Contributor

The PR fix: enhance feed layout responsiveness #1538 will fix the issue.

@RitaDee RitaDee mentioned this issue Aug 14, 2023
Merged
19 tasks
@brandonroberts brandonroberts added high-priority Work on these issues first and removed 👀 needs triage labels Aug 14, 2023
@open-sauced
Copy link
Contributor

open-sauced bot commented Aug 14, 2023

🎉 This issue has been resolved in version 1.60.0-beta.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced
Copy link
Contributor

open-sauced bot commented Aug 16, 2023

🎉 This issue has been resolved in version 1.60.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced open-sauced bot added the released label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working high-priority Work on these issues first released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: enhance feed layout responsiveness RitaDee/insights
5 participants
@brandonroberts @bdougie @a0m0rajab @babblebey @takanome-dev