Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repository insight limited features #3876

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Conversation

zeucapua
Copy link
Contributor

@zeucapua zeucapua commented Aug 6, 2024

Description

  • User can click the 'Edit' button to go to settings
    • previously shows the Upgrade Modal
  • Show banner on /edit page

Related Tickets & Documents

Closes #3875

Mobile & Desktop Screenshots/Recordings

Arc

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

@zeucapua zeucapua marked this pull request as draft August 6, 2024 21:35
Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit ed5c0ae
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66b2a01227c2c00008bfe3d6
😎 Deploy Preview https://deploy-preview-3876--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit ed5c0ae
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66b2a01243d145000853181e
😎 Deploy Preview https://deploy-preview-3876--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zeucapua zeucapua marked this pull request as ready for review August 6, 2024 22:13
@zeucapua zeucapua requested a review from a team August 6, 2024 22:13
Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now works as expected

@zeucapua zeucapua merged commit 5ef6bd6 into beta Aug 6, 2024
13 checks passed
@zeucapua zeucapua deleted the fix/repo-insight-edit-gate branch August 6, 2024 23:06
open-sauced bot pushed a commit that referenced this pull request Aug 6, 2024
## [2.51.1-beta.1](v2.51.0...v2.51.1-beta.1) (2024-08-06)

### 🐛 Bug Fixes

* repository insight limited features ([#3876](#3876)) ([5ef6bd6](5ef6bd6))
open-sauced bot pushed a commit that referenced this pull request Aug 9, 2024
## [2.52.0](v2.51.0...v2.52.0) (2024-08-09)

### 🍕 Features

* add OSCR tooltip to user page ([#3857](#3857)) ([fd5fa41](fd5fa41))
* add OSCR's location to PostHog capture ([#3895](#3895)) ([bbf8ee5](bbf8ee5))
* now OSCR appears on repository page contributor grid view ([#3884](#3884)) ([d7163d8](d7163d8))
* repository page contributor graph defaults to enhance by default now ([#3880](#3880)) ([90948a5](90948a5))
* tracking DevCard analytics ([#3874](#3874)) ([583e42a](583e42a))

### 🐛 Bug Fixes

* calculate avergage per week for ross contributors greater than 0 ([#3893](#3893)) ([a8859c5](a8859c5))
* excluded OSCR from old contributor card list component ([#3901](#3901)) ([446f27c](446f27c))
* now layout toggles are radio buttons ([#3888](#3888)) ([efba1f8](efba1f8))
* now the contributor card user profile link no longer affects the OSCR login flow ([#3898](#3898)) ([7405660](7405660))
* now the contributor scatter chart toggle group has a label ([#3882](#3882)) ([adf5c6c](adf5c6c))
* Removes NewsletterForm usage in favor of sole link to newsletter ([#3897](#3897)) ([61951ff](61951ff))
* repository insight limited features ([#3876](#3876)) ([5ef6bd6](5ef6bd6))
* show loading indicator for contributor confidence if undefined ([#3894](#3894)) ([3032a6a](3032a6a))
* update profile interests type to be optional and add guards ([#3890](#3890)) ([2e62773](2e62773))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: can't delete insight that's over limit
3 participants