Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add OSCR tooltip to user page #3857

Merged
merged 10 commits into from
Aug 8, 2024
Merged

feat: add OSCR tooltip to user page #3857

merged 10 commits into from
Aug 8, 2024

Conversation

zeucapua
Copy link
Contributor

@zeucapua zeucapua commented Aug 5, 2024

Description

Implements an InfoTooltip to the user page (/u/[username]) to explain what OSCR is.

Related Tickets & Documents

Closes #3854

Mobile & Desktop Screenshots/Recordings

Steps to QA

  1. Go to any user page

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 25fee67
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66b53c892b5a950008e718f3
😎 Deploy Preview https://deploy-preview-3857--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 25fee67
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66b53c89e1fd9200089d90d5
😎 Deploy Preview https://deploy-preview-3857--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The info tooltip works, but it's super small. It's hard to tell what it is as it looks like a circle with a small dot in it.

CleanShot 2024-08-05 at 14 36 46

@zeucapua zeucapua requested review from nickytonline and a team August 5, 2024 19:14
Copy link
Member

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy looks great!

@brandonroberts brandonroberts added the merge conflicts Needs merge conflict resolved label Aug 7, 2024
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after chatting about it in our 1:1 that you'll be making the suggested changes.

@jpmcb jpmcb removed the merge conflicts Needs merge conflict resolved label Aug 8, 2024
@zeucapua zeucapua merged commit fd5fa41 into beta Aug 8, 2024
13 checks passed
@zeucapua zeucapua deleted the feat/user-oscr-tooltip branch August 8, 2024 21:52
open-sauced bot pushed a commit that referenced this pull request Aug 8, 2024
## [2.52.0-beta.11](v2.52.0-beta.10...v2.52.0-beta.11) (2024-08-08)

### 🍕 Features

* add OSCR tooltip to user page ([#3857](#3857)) ([fd5fa41](fd5fa41))
open-sauced bot pushed a commit that referenced this pull request Aug 9, 2024
## [2.52.0](v2.51.0...v2.52.0) (2024-08-09)

### 🍕 Features

* add OSCR tooltip to user page ([#3857](#3857)) ([fd5fa41](fd5fa41))
* add OSCR's location to PostHog capture ([#3895](#3895)) ([bbf8ee5](bbf8ee5))
* now OSCR appears on repository page contributor grid view ([#3884](#3884)) ([d7163d8](d7163d8))
* repository page contributor graph defaults to enhance by default now ([#3880](#3880)) ([90948a5](90948a5))
* tracking DevCard analytics ([#3874](#3874)) ([583e42a](583e42a))

### 🐛 Bug Fixes

* calculate avergage per week for ross contributors greater than 0 ([#3893](#3893)) ([a8859c5](a8859c5))
* excluded OSCR from old contributor card list component ([#3901](#3901)) ([446f27c](446f27c))
* now layout toggles are radio buttons ([#3888](#3888)) ([efba1f8](efba1f8))
* now the contributor card user profile link no longer affects the OSCR login flow ([#3898](#3898)) ([7405660](7405660))
* now the contributor scatter chart toggle group has a label ([#3882](#3882)) ([adf5c6c](adf5c6c))
* Removes NewsletterForm usage in favor of sole link to newsletter ([#3897](#3897)) ([61951ff](61951ff))
* repository insight limited features ([#3876](#3876)) ([5ef6bd6](5ef6bd6))
* show loading indicator for contributor confidence if undefined ([#3894](#3894)) ([3032a6a](3032a6a))
* update profile interests type to be optional and add guards ([#3890](#3890)) ([2e62773](2e62773))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Describe OSCR rating
4 participants