Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show loading indicator for contributor confidence if undefined #3894

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

brandonroberts
Copy link
Contributor

@brandonroberts brandonroberts commented Aug 8, 2024

Description

  • Fixes an issue where the contributor confidence shows the loading spinner if the value is 0

Related Tickets & Documents

Fixes #3900

Mobile & Desktop Screenshots/Recordings

Steps to QA

  1. Visit https://beta.app.opensauced.pizza/s/jpmcb/gopherlogs
  2. Note the loading spinner for contributor confidence never stops
  3. Vist https://deploy-preview-3894--oss-insights.netlify.app/s/jpmcb/gopherlogs
  4. Not the loading spinner and then contributor confidence is displayed

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

@brandonroberts brandonroberts requested a review from a team August 8, 2024 16:56
Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit eb181ef
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66b54e1406444f0008d2eb91
😎 Deploy Preview https://deploy-preview-3894--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit eb181ef
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66b54e147e752c00089623dc
😎 Deploy Preview https://deploy-preview-3894--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandonroberts brandonroberts merged commit 3032a6a into beta Aug 9, 2024
13 checks passed
@brandonroberts brandonroberts deleted the fix-contributor-conf-loading branch August 9, 2024 02:42
open-sauced bot pushed a commit that referenced this pull request Aug 9, 2024
## [2.52.0-beta.12](v2.52.0-beta.11...v2.52.0-beta.12) (2024-08-09)

### 🐛 Bug Fixes

* show loading indicator for contributor confidence if undefined ([#3894](#3894)) ([3032a6a](3032a6a))
* update profile interests type to be optional and add guards ([#3890](#3890)) ([2e62773](2e62773))
open-sauced bot pushed a commit that referenced this pull request Aug 9, 2024
## [2.52.0](v2.51.0...v2.52.0) (2024-08-09)

### 🍕 Features

* add OSCR tooltip to user page ([#3857](#3857)) ([fd5fa41](fd5fa41))
* add OSCR's location to PostHog capture ([#3895](#3895)) ([bbf8ee5](bbf8ee5))
* now OSCR appears on repository page contributor grid view ([#3884](#3884)) ([d7163d8](d7163d8))
* repository page contributor graph defaults to enhance by default now ([#3880](#3880)) ([90948a5](90948a5))
* tracking DevCard analytics ([#3874](#3874)) ([583e42a](583e42a))

### 🐛 Bug Fixes

* calculate avergage per week for ross contributors greater than 0 ([#3893](#3893)) ([a8859c5](a8859c5))
* excluded OSCR from old contributor card list component ([#3901](#3901)) ([446f27c](446f27c))
* now layout toggles are radio buttons ([#3888](#3888)) ([efba1f8](efba1f8))
* now the contributor card user profile link no longer affects the OSCR login flow ([#3898](#3898)) ([7405660](7405660))
* now the contributor scatter chart toggle group has a label ([#3882](#3882)) ([adf5c6c](adf5c6c))
* Removes NewsletterForm usage in favor of sole link to newsletter ([#3897](#3897)) ([61951ff](61951ff))
* repository insight limited features ([#3876](#3876)) ([5ef6bd6](5ef6bd6))
* show loading indicator for contributor confidence if undefined ([#3894](#3894)) ([3032a6a](3032a6a))
* update profile interests type to be optional and add guards ([#3890](#3890)) ([2e62773](2e62773))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: when confidence is 0, repo page "Contributor confidence" chart spins forever
3 participants