feat: vote repos #70

diivi · 2023-05-06T23:31:28Z

What type of PR is this? (check all applicable)

Description

Adds a feature that allows users to vote/unvote for repos directly from GitHub, by checking if the user is logged in && the repo exists on opensauced.
If user has already voted repo, show the unvote button else show the vote button.
The DOM-manipulation part is done, styling and voting/ removing votes remains.

Related Tickets & Documents

#9

Mobile & Desktop Screenshots/Recordings

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Anush008

Looks good @diivi. I've suggested a change for you to consider.

src/content-scripts/components/RepoVoting/RepoUnvoteButton.ts

bdougie · 2023-05-07T15:05:20Z

I understand this will need a few updates and future PRs. There are few visual things.

button is not aligned or sized with others
Font on the button should match GitHub.
Button is cut off on smaller screens.

Anush008 · 2023-05-07T15:10:59Z

I think we can clone the GH star button itself, it has a drop-down which will be of good use to us when adding the "Add repo to OS Insights page" feature.

diivi · 2023-05-08T07:20:42Z

Anush008 · 2023-05-08T11:05:10Z

Great! 👍

Anush008

Hey @diivi, we'll be needing a check like the one here https://github.com/open-sauced/browser-extensions/blob/7eb4c761a5f7964ac8ed4f92703f20b1ce7ebca2/src/utils/dom-utils/inviteToOpenSauced.ts#L38-L40 before appending the vote button or the duplicated button issue #46 arises.

diivi · 2023-05-09T09:27:24Z

Nice catch, done!

diivi · 2023-05-09T14:40:04Z

Btw @Anush008, I am unable to reproduce it now but I saw the same thing happen with the "add PR as insight" button earlier today.

Anush008 · 2023-05-10T01:45:11Z

I'll check to see if I can reproduce the same.

bdougie · 2023-05-10T02:54:52Z

This works for me visually, it just feels weird to approve without having unvoting live.

diivi · 2023-05-10T13:18:22Z

This works for me visually, it just feels weird to approve without having unvoting live.

Unvoting is a part of this PR, do you mean the bug with unvoting in the API?

bdougie · 2023-05-11T18:44:09Z

Unvoting is a part of this PR, do you mean the bug with unvoting in the API?

Yes, we will need to fix the bug. Leaving a comment there for an approach to move forward.

https://github.com/open-sauced/api.opensauced.pizza/issues/122

diivi · 2023-05-12T17:07:21Z

@bdougie Now that the blocker has been removed, we can merge this after your review and get started with "add repo to insights".

## [1.0.0-beta.10](v1.0.0-beta.9...v1.0.0-beta.10) (2023-05-12) ### 🍕 Features * vote repos ([#70](#70)) ([ff2c8f4](ff2c8f4))

github-actions · 2023-05-12T17:10:45Z

🎉 This PR is included in version 1.0.0-beta.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## 1.0.0 (2023-05-13) ### 📝 Documentation * README and LICENSE ([917f7b0](917f7b0)) * Updated the README.md ([#15](#15)) ([3e4dd69](3e4dd69)) ### 🔁 Continuous Integration * automated github releases ([#39](#39)) ([735fa66](735fa66)), closes [#16](#16) ### 🧑‍💻 Code Refactoring * improved-auth-strategy ([#56](#56)) ([d8b27c3](d8b27c3)) ### 🍕 Features * add home page and profile page ([#36](#36)) ([8a43288](8a43288)) * add to highlights button ([#64](#64)) ([e2120a1](e2120a1)) * Added a configuration file ([#32](#32)) ([ec6722c](ec6722c)) * Added light mode to GH profile buttons ([#40](#40)) ([a7ea43a](a7ea43a)) * Added linting to the project. ([#49](#49)) ([1f73007](1f73007)) * Auto PAT authentication ([#29](#29)) ([f4f8cf6](f4f8cf6)) * extension window navigation ([#21](#21)) ([b5ae9a6](b5ae9a6)) * GitHub page update listener ([#37](#37)) ([06b070f](06b070f)) * Invite to OpenSauced ([#20](#20)) ([0c8f222](0c8f222)) * PAT authentication ([#27](#27)) ([e726a93](e726a93)) * updated the extension logo ([#22](#22)) ([d19034d](d19034d)) * view on OpenSauced button ([#14](#14)) ([a447551](a447551)) * vote repos ([#70](#70)) ([ff2c8f4](ff2c8f4)) ### 🐛 Bug Fixes * rename the. extension ([294e499](294e499)) * Update URLs ([5828e20](5828e20)) * attach dist folder to release assets ([#47](#47)) ([4f50e72](4f50e72)) * circular-deps in vote buttons ([675496c](675496c)) * Duplicate buttons on GH profile page ([#48](#48)) ([9ee2dca](9ee2dca)) * incorrect request for voting ([#72](#72)) ([7a35014](7a35014)) * make emails less creepy ([a08fa45](a08fa45)) * re-enable tailwind base class on extension popup ([#31](#31)) ([c081217](c081217)) * remove activeTab manifest.json ([#50](#50)) ([dd71480](dd71480)) * render emojis in user bio ([#68](#68)) ([d0158a5](d0158a5)) * set-output deprecation warning ([#51](#51)) ([486f84b](486f84b)) * unrecognized-manifest-key ([#55](#55)) ([d622500](d622500)) * Wrapped the await call in an async() ([#26](#26)) ([357aab5](357aab5))

github-actions · 2023-05-13T13:16:11Z

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.0.0-beta.10](open-sauced/ai@v1.0.0-beta.9...v1.0.0-beta.10) (2023-05-12) ### 🍕 Features * vote repos ([#70](open-sauced/ai#70)) ([ff2c8f4](open-sauced/ai@ff2c8f4))

## 1.0.0 (2023-05-13) ### 📝 Documentation * README and LICENSE ([917f7b0](open-sauced/ai@917f7b0)) * Updated the README.md ([#15](open-sauced/ai#15)) ([3e4dd69](open-sauced/ai@3e4dd69)) ### 🔁 Continuous Integration * automated github releases ([#39](open-sauced/ai#39)) ([735fa66](open-sauced/ai@735fa66)), closes [#16](open-sauced/ai#16) ### 🧑‍💻 Code Refactoring * improved-auth-strategy ([#56](open-sauced/ai#56)) ([d8b27c3](open-sauced/ai@d8b27c3)) ### 🍕 Features * add home page and profile page ([#36](open-sauced/ai#36)) ([8a43288](open-sauced/ai@8a43288)) * add to highlights button ([#64](open-sauced/ai#64)) ([e2120a1](open-sauced/ai@e2120a1)) * Added a configuration file ([#32](open-sauced/ai#32)) ([ec6722c](open-sauced/ai@ec6722c)) * Added light mode to GH profile buttons ([#40](open-sauced/ai#40)) ([a7ea43a](open-sauced/ai@a7ea43a)) * Added linting to the project. ([#49](open-sauced/ai#49)) ([1f73007](open-sauced/ai@1f73007)) * Auto PAT authentication ([#29](open-sauced/ai#29)) ([f4f8cf6](open-sauced/ai@f4f8cf6)) * extension window navigation ([#21](open-sauced/ai#21)) ([b5ae9a6](open-sauced/ai@b5ae9a6)) * GitHub page update listener ([#37](open-sauced/ai#37)) ([06b070f](open-sauced/ai@06b070f)) * Invite to OpenSauced ([#20](open-sauced/ai#20)) ([0c8f222](open-sauced/ai@0c8f222)) * PAT authentication ([#27](open-sauced/ai#27)) ([e726a93](open-sauced/ai@e726a93)) * updated the extension logo ([#22](open-sauced/ai#22)) ([d19034d](open-sauced/ai@d19034d)) * view on OpenSauced button ([#14](open-sauced/ai#14)) ([a447551](open-sauced/ai@a447551)) * vote repos ([#70](open-sauced/ai#70)) ([ff2c8f4](open-sauced/ai@ff2c8f4)) ### 🐛 Bug Fixes * rename the. extension ([294e499](open-sauced/ai@294e499)) * Update URLs ([5828e20](open-sauced/ai@5828e20)) * attach dist folder to release assets ([#47](open-sauced/ai#47)) ([4f50e72](open-sauced/ai@4f50e72)) * circular-deps in vote buttons ([675496c](open-sauced/ai@675496c)) * Duplicate buttons on GH profile page ([#48](open-sauced/ai#48)) ([9ee2dca](open-sauced/ai@9ee2dca)) * incorrect request for voting ([#72](open-sauced/ai#72)) ([7a35014](open-sauced/ai@7a35014)) * make emails less creepy ([a08fa45](open-sauced/ai@a08fa45)) * re-enable tailwind base class on extension popup ([#31](open-sauced/ai#31)) ([c081217](open-sauced/ai@c081217)) * remove activeTab manifest.json ([#50](open-sauced/ai#50)) ([dd71480](open-sauced/ai@dd71480)) * render emojis in user bio ([#68](open-sauced/ai#68)) ([d0158a5](open-sauced/ai@d0158a5)) * set-output deprecation warning ([#51](open-sauced/ai#51)) ([486f84b](open-sauced/ai@486f84b)) * unrecognized-manifest-key ([#55](open-sauced/ai#55)) ([d622500](open-sauced/ai@d622500)) * Wrapped the await call in an async() ([#26](open-sauced/ai#26)) ([357aab5](open-sauced/ai@357aab5))

diivi added 3 commits May 7, 2023 04:59

feat: vote repos

893ff58

remove logs, enable voting and allow all comments

f139529

final ui/ux changes

0589d54

diivi marked this pull request as ready for review May 7, 2023 00:11

Anush008 suggested changes May 7, 2023

View reviewed changes

src/content-scripts/components/RepoVoting/RepoUnvoteButton.ts Outdated Show resolved Hide resolved

match repo actions dimensions and refactor code

7d9482c

diivi requested review from bdougie and Anush008 May 8, 2023 07:18

remove border tag that makes dimensions different

90ed645

Anush008 approved these changes May 8, 2023

View reviewed changes

Anush008 suggested changes May 8, 2023

View reviewed changes

prevent duplicate node append

25363ed

diivi requested a review from Anush008 May 9, 2023 09:27

Anush008 approved these changes May 9, 2023

View reviewed changes

bdougie approved these changes May 12, 2023

View reviewed changes

bdougie merged commit ff2c8f4 into beta May 12, 2023

github-actions bot pushed a commit that referenced this pull request May 12, 2023

chore(minor): release 1.0.0-beta.10 on beta channel [skip ci]

99e0f0e

## [1.0.0-beta.10](v1.0.0-beta.9...v1.0.0-beta.10) (2023-05-12) ### 🍕 Features * vote repos ([#70](#70)) ([ff2c8f4](ff2c8f4))

github-actions bot added the released on @beta label May 12, 2023

Anush008 deleted the feat/vote-repos branch May 13, 2023 01:28

github-actions bot added the released label May 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: vote repos #70

feat: vote repos #70

diivi commented May 6, 2023 •

edited

Loading

Anush008 left a comment

bdougie commented May 7, 2023

Anush008 commented May 7, 2023 •

edited

Loading

diivi commented May 8, 2023 •

edited

Loading

Anush008 commented May 8, 2023

Anush008 left a comment •

edited

Loading

diivi commented May 9, 2023

diivi commented May 9, 2023

Anush008 commented May 10, 2023

bdougie commented May 10, 2023

diivi commented May 10, 2023

bdougie commented May 11, 2023

diivi commented May 12, 2023

github-actions bot commented May 12, 2023

github-actions bot commented May 13, 2023

feat: vote repos #70

feat: vote repos #70

Conversation

diivi commented May 6, 2023 • edited Loading

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Anush008 left a comment

Choose a reason for hiding this comment

bdougie commented May 7, 2023

Anush008 commented May 7, 2023 • edited Loading

diivi commented May 8, 2023 • edited Loading

Anush008 commented May 8, 2023

Anush008 left a comment • edited Loading

Choose a reason for hiding this comment

diivi commented May 9, 2023

diivi commented May 9, 2023

Anush008 commented May 10, 2023

bdougie commented May 10, 2023

diivi commented May 10, 2023

bdougie commented May 11, 2023

diivi commented May 12, 2023

github-actions bot commented May 12, 2023

github-actions bot commented May 13, 2023

diivi commented May 6, 2023 •

edited

Loading

Anush008 commented May 7, 2023 •

edited

Loading

diivi commented May 8, 2023 •

edited

Loading

Anush008 left a comment •

edited

Loading