Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Copy hot.opensauced CI and tooling #16

Closed
1 of 2 tasks
bdougie opened this issue Apr 17, 2023 · 13 comments · Fixed by #39
Closed
1 of 2 tasks

Feature: Copy hot.opensauced CI and tooling #16

bdougie opened this issue Apr 17, 2023 · 13 comments · Fixed by #39

Comments

@bdougie
Copy link
Member

bdougie commented Apr 17, 2023

Type of feature

🍕 Feature

Current behavior

cc @0-vortex

https://github.com/open-sauced/hot/tree/beta/.github/workflows

Suggested solution

The release.yml is needed to generate the dist and zip, but it will need some updates to the package.json.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@bdougie
Copy link
Member Author

bdougie commented Apr 17, 2023

Sorry, let's wait on this and get the extension functional first @Anush008. Actions are disabled on this repo for now.

@bdougie
Copy link
Member Author

bdougie commented Apr 22, 2023

We may be ready to start adding CI/build things now that the extension works. @diivi I am assigning it to you, but we can chat through it on Monday.

  1. Copy portions of the hot repo CI - https://github.com/open-sauced/hot/blob/beta/.github/workflows/release.yml
  2. Build should include zipping the dist output.
  3. zip should get added to GitHub Packages.

If you haven't done this, that is fine. We are going to keep it simple and @0-vortex can also answer questions as well.

@0-vortex
Copy link

We may be ready to start adding CI/build things now that the extension works. @diivi I am assigning it to you, but we can chat through it on Monday.

  1. Copy portions of the hot repo CI - https://github.com/open-sauced/hot/blob/beta/.github/workflows/release.yml
  2. Build should include zipping the dist output.
  3. zip should get added to GitHub Packages.

If you haven't done this, that is fine. We are going to keep it simple and @0-vortex can also answer questions as well.

Ready to help! ❤️

@bdougie bdougie moved this from Todo to In Progress in Extension Status Board Apr 24, 2023
@diivi
Copy link
Contributor

diivi commented Apr 24, 2023

@0-vortex I tried copying the config in my fork, I am getting the following error when I run the workflow:

image

My workflow file:
https://github.com/diivi/browser-extensions/actions/runs/4791902136/workflow

It's probably because opensauced/releases uses node v16, but it works fine with other repos.

Can you suggest a solution for this?

@takanome-dev
Copy link

It's probably because opensauced/releases uses node v16, but it works fine with other repos.

Can you provide links to the repos you are referring to?
The hot and insights repos use node@16 for the release action.

Can you suggest a solution for this?

Did you try to build the project with node@16, upload it using actions/upload-artifact and download it with actions/download-artifact before using the release action?
That's how it's done here

@0-vortex
Copy link

0-vortex commented Apr 25, 2023

@0-vortex I tried copying the config in my fork, I am getting the following error when I run the workflow:

image

My workflow file: https://github.com/diivi/browser-extensions/actions/runs/4791902136/workflow

It's probably because opensauced/releases uses node v16, but it works fine with other repos.

Can you suggest a solution for this?

You are trying to run the build and release step at the same time, that's why you get conflicts, the release action is running dockerized expecting to be in a sandbox (this is in order for us to not install devDependencies like semantic-release npm packages and attach a config to every repo)

Like @takanome-dev suggested in #16 (comment) a copy paste of that file with minor changes is what it should look like 🍕

@diivi
Copy link
Contributor

diivi commented Apr 26, 2023

I was able to get this working, just one more thing, how do I add the dist folder as a zip file to the release assets? Here's the new workflow file that I tried doing this with - https://github.com/diivi/browser-extensions/actions/runs/4812113139/workflow

@0-vortex
Copy link

I was able to get this working, just one more thing, how do I add the dist folder as a zip file to the release assets? Here's the new workflow file that I tried doing this with - https://github.com/diivi/browser-extensions/actions/runs/4812113139/workflow

the steps here are correct: https://github.com/diivi/browser-extensions/actions/runs/4812113139/workflow#L67-L77

however, the automatic archiving from semantic-release happening here: https://github.com/open-sauced/release/blob/main/release.config.js#L141-L149

is actually handled by npm pack and the configuration in package.json - https://docs.npmjs.com/cli/v9/commands/npm-pack?v=true should be helpful in debugging this

These steps here are duplicating the release flow: https://github.com/diivi/browser-extensions/actions/runs/4812113139/workflow#L79-L88 suggest removing those completely 🍕

@bdougie
Copy link
Member Author

bdougie commented Apr 27, 2023

How about we create a beta branch and make that default and test the releases by doing the above changes and testing it out. Alternatively, we can test it in your fork @diivi

@diivi
Copy link
Contributor

diivi commented Apr 27, 2023

@0-vortex wouldn't the steps you mentioned work only with tgz archives?

@bdougie wanted just a .zip archive to be attached to releases so he could upload it directly to the chrome extension store.

@bdougie
Copy link
Member Author

bdougie commented Apr 27, 2023

tgz is fine. Since there will not be an automated process to deploy to production, we just need a version uploaded. Type is not relevant.

@diivi diivi mentioned this issue Apr 27, 2023
19 tasks
bdougie pushed a commit that referenced this issue Apr 27, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Extension Status Board Apr 27, 2023
github-actions bot pushed a commit that referenced this issue Apr 27, 2023
## 1.0.0-beta.1 (2023-04-27)

### 📝 Documentation

* README and LICENSE ([917f7b0](917f7b0))
* Updated the README.md ([#15](#15)) ([3e4dd69](3e4dd69))

### 🐛 Bug Fixes

*  rename the. extension ([294e499](294e499))
*  Update URLs ([5828e20](5828e20))
* make emails less creepy ([a08fa45](a08fa45))
* re-enable tailwind base class on extension popup ([#31](#31)) ([c081217](c081217))
* Wrapped the await call in an async() ([#26](#26)) ([357aab5](357aab5))

### 🍕 Features

* add home page and profile page ([#36](#36)) ([8a43288](8a43288))
* Added a configuration file ([#32](#32)) ([ec6722c](ec6722c))
* Auto PAT authentication ([#29](#29)) ([f4f8cf6](f4f8cf6))
* extension window navigation ([#21](#21)) ([b5ae9a6](b5ae9a6))
* GitHub page update listener ([#37](#37)) ([06b070f](06b070f))
* Invite to OpenSauced ([#20](#20)) ([0c8f222](0c8f222))
* PAT authentication ([#27](#27)) ([e726a93](e726a93))
* updated the extension logo ([#22](#22)) ([d19034d](d19034d))
* view on OpenSauced button ([#14](#14)) ([a447551](a447551))

### 🔁 Continuous Integration

* automated github releases ([#39](#39)) ([735fa66](735fa66)), closes [#16](#16)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue May 13, 2023
## 1.0.0 (2023-05-13)

### 📝 Documentation

* README and LICENSE ([917f7b0](917f7b0))
* Updated the README.md ([#15](#15)) ([3e4dd69](3e4dd69))

### 🔁 Continuous Integration

* automated github releases ([#39](#39)) ([735fa66](735fa66)), closes [#16](#16)

### 🧑‍💻 Code Refactoring

* improved-auth-strategy ([#56](#56)) ([d8b27c3](d8b27c3))

### 🍕 Features

* add home page and profile page ([#36](#36)) ([8a43288](8a43288))
* add to highlights button ([#64](#64)) ([e2120a1](e2120a1))
* Added a configuration file ([#32](#32)) ([ec6722c](ec6722c))
* Added light mode to GH profile buttons ([#40](#40)) ([a7ea43a](a7ea43a))
* Added linting to the project. ([#49](#49)) ([1f73007](1f73007))
* Auto PAT authentication ([#29](#29)) ([f4f8cf6](f4f8cf6))
* extension window navigation ([#21](#21)) ([b5ae9a6](b5ae9a6))
* GitHub page update listener ([#37](#37)) ([06b070f](06b070f))
* Invite to OpenSauced ([#20](#20)) ([0c8f222](0c8f222))
* PAT authentication ([#27](#27)) ([e726a93](e726a93))
* updated the extension logo ([#22](#22)) ([d19034d](d19034d))
* view on OpenSauced button ([#14](#14)) ([a447551](a447551))
* vote repos ([#70](#70)) ([ff2c8f4](ff2c8f4))

### 🐛 Bug Fixes

*  rename the. extension ([294e499](294e499))
*  Update URLs ([5828e20](5828e20))
* attach dist folder to release assets ([#47](#47)) ([4f50e72](4f50e72))
* circular-deps in vote buttons ([675496c](675496c))
* Duplicate buttons on GH profile page ([#48](#48)) ([9ee2dca](9ee2dca))
* incorrect request for voting ([#72](#72)) ([7a35014](7a35014))
* make emails less creepy ([a08fa45](a08fa45))
* re-enable tailwind base class on extension popup ([#31](#31)) ([c081217](c081217))
* remove activeTab manifest.json ([#50](#50)) ([dd71480](dd71480))
* render emojis in user bio ([#68](#68)) ([d0158a5](d0158a5))
* set-output deprecation warning ([#51](#51)) ([486f84b](486f84b))
* unrecognized-manifest-key ([#55](#55)) ([d622500](d622500))
* Wrapped the await call in an async() ([#26](#26)) ([357aab5](357aab5))
@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@estaaarrr estaaarrr moved this from Done to Blocked in Extension Status Board Jul 4, 2023
@bdougie bdougie moved this from Blocked to Done in Extension Status Board Jul 7, 2023
zer0and1 pushed a commit to zer0and1/open-sauced.ai that referenced this issue Jul 26, 2023
## 1.0.0-beta.1 (2023-04-27)

### 📝 Documentation

* README and LICENSE ([917f7b0](open-sauced/ai@917f7b0))
* Updated the README.md ([#15](open-sauced/ai#15)) ([3e4dd69](open-sauced/ai@3e4dd69))

### 🐛 Bug Fixes

*  rename the. extension ([294e499](open-sauced/ai@294e499))
*  Update URLs ([5828e20](open-sauced/ai@5828e20))
* make emails less creepy ([a08fa45](open-sauced/ai@a08fa45))
* re-enable tailwind base class on extension popup ([#31](open-sauced/ai#31)) ([c081217](open-sauced/ai@c081217))
* Wrapped the await call in an async() ([#26](open-sauced/ai#26)) ([357aab5](open-sauced/ai@357aab5))

### 🍕 Features

* add home page and profile page ([#36](open-sauced/ai#36)) ([8a43288](open-sauced/ai@8a43288))
* Added a configuration file ([#32](open-sauced/ai#32)) ([ec6722c](open-sauced/ai@ec6722c))
* Auto PAT authentication ([#29](open-sauced/ai#29)) ([f4f8cf6](open-sauced/ai@f4f8cf6))
* extension window navigation ([#21](open-sauced/ai#21)) ([b5ae9a6](open-sauced/ai@b5ae9a6))
* GitHub page update listener ([#37](open-sauced/ai#37)) ([06b070f](open-sauced/ai@06b070f))
* Invite to OpenSauced ([#20](open-sauced/ai#20)) ([0c8f222](open-sauced/ai@0c8f222))
* PAT authentication ([#27](open-sauced/ai#27)) ([e726a93](open-sauced/ai@e726a93))
* updated the extension logo ([#22](open-sauced/ai#22)) ([d19034d](open-sauced/ai@d19034d))
* view on OpenSauced button ([#14](open-sauced/ai#14)) ([a447551](open-sauced/ai@a447551))

### 🔁 Continuous Integration

* automated github releases ([#39](open-sauced/ai#39)) ([735fa66](open-sauced/ai@735fa66)), closes [#16](open-sauced/ai#16)
zer0and1 pushed a commit to zer0and1/open-sauced.ai that referenced this issue Jul 26, 2023
## 1.0.0 (2023-05-13)

### 📝 Documentation

* README and LICENSE ([917f7b0](open-sauced/ai@917f7b0))
* Updated the README.md ([#15](open-sauced/ai#15)) ([3e4dd69](open-sauced/ai@3e4dd69))

### 🔁 Continuous Integration

* automated github releases ([#39](open-sauced/ai#39)) ([735fa66](open-sauced/ai@735fa66)), closes [#16](open-sauced/ai#16)

### 🧑‍💻 Code Refactoring

* improved-auth-strategy ([#56](open-sauced/ai#56)) ([d8b27c3](open-sauced/ai@d8b27c3))

### 🍕 Features

* add home page and profile page ([#36](open-sauced/ai#36)) ([8a43288](open-sauced/ai@8a43288))
* add to highlights button ([#64](open-sauced/ai#64)) ([e2120a1](open-sauced/ai@e2120a1))
* Added a configuration file ([#32](open-sauced/ai#32)) ([ec6722c](open-sauced/ai@ec6722c))
* Added light mode to GH profile buttons ([#40](open-sauced/ai#40)) ([a7ea43a](open-sauced/ai@a7ea43a))
* Added linting to the project. ([#49](open-sauced/ai#49)) ([1f73007](open-sauced/ai@1f73007))
* Auto PAT authentication ([#29](open-sauced/ai#29)) ([f4f8cf6](open-sauced/ai@f4f8cf6))
* extension window navigation ([#21](open-sauced/ai#21)) ([b5ae9a6](open-sauced/ai@b5ae9a6))
* GitHub page update listener ([#37](open-sauced/ai#37)) ([06b070f](open-sauced/ai@06b070f))
* Invite to OpenSauced ([#20](open-sauced/ai#20)) ([0c8f222](open-sauced/ai@0c8f222))
* PAT authentication ([#27](open-sauced/ai#27)) ([e726a93](open-sauced/ai@e726a93))
* updated the extension logo ([#22](open-sauced/ai#22)) ([d19034d](open-sauced/ai@d19034d))
* view on OpenSauced button ([#14](open-sauced/ai#14)) ([a447551](open-sauced/ai@a447551))
* vote repos ([#70](open-sauced/ai#70)) ([ff2c8f4](open-sauced/ai@ff2c8f4))

### 🐛 Bug Fixes

*  rename the. extension ([294e499](open-sauced/ai@294e499))
*  Update URLs ([5828e20](open-sauced/ai@5828e20))
* attach dist folder to release assets ([#47](open-sauced/ai#47)) ([4f50e72](open-sauced/ai@4f50e72))
* circular-deps in vote buttons ([675496c](open-sauced/ai@675496c))
* Duplicate buttons on GH profile page ([#48](open-sauced/ai#48)) ([9ee2dca](open-sauced/ai@9ee2dca))
* incorrect request for voting ([#72](open-sauced/ai#72)) ([7a35014](open-sauced/ai@7a35014))
* make emails less creepy ([a08fa45](open-sauced/ai@a08fa45))
* re-enable tailwind base class on extension popup ([#31](open-sauced/ai#31)) ([c081217](open-sauced/ai@c081217))
* remove activeTab manifest.json ([#50](open-sauced/ai#50)) ([dd71480](open-sauced/ai@dd71480))
* render emojis in user bio ([#68](open-sauced/ai#68)) ([d0158a5](open-sauced/ai@d0158a5))
* set-output deprecation warning ([#51](open-sauced/ai#51)) ([486f84b](open-sauced/ai@486f84b))
* unrecognized-manifest-key ([#55](open-sauced/ai#55)) ([d622500](open-sauced/ai@d622500))
* Wrapped the await call in an async() ([#26](open-sauced/ai#26)) ([357aab5](open-sauced/ai@357aab5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

5 participants