Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Duplicate buttons when switching tabs on a user's profile #46

Closed
2 tasks done
diivi opened this issue Apr 27, 2023 · 3 comments · Fixed by #48
Closed
2 tasks done

Bug: Duplicate buttons when switching tabs on a user's profile #46

diivi opened this issue Apr 27, 2023 · 3 comments · Fixed by #48
Assignees
Labels

Comments

@diivi
Copy link
Contributor

diivi commented Apr 27, 2023

Describe the bug

image

When switching from the overview to the repositories tab, a duplicate "View on OpenSauced" Button gets added to the webpage.

Steps to reproduce

  1. Go to a profile
  2. Click on repositories

Affected services

browser-extension

Platforms

Desktop

Browsers

Chrome

Environment

Production

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@diivi diivi added the 🐛 bug Something isn't working label Apr 27, 2023
@Anush008
Copy link
Member

I think the problem lies here: https://github.com/open-sauced/browser-extensions/blob/41188a32f6e3a8651c174fd1afce2d473b6dfc1c/src/utils/dom-utils/viewOnOpenSauced.ts#L20.
userBio.parentNode.replaceChild is accumulating the viewOnOpenSaucedButton added previously. Should be an easy fix. I'll patch it.

@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.0-beta.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants