Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added linting to the project #45

Closed
wants to merge 9 commits into from
Closed

feat: added linting to the project #45

wants to merge 9 commits into from

Conversation

Anush008
Copy link
Member

@Anush008 Anush008 commented Apr 27, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR proposes the following changes:

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Not applicable.

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

@Anush008 Anush008 requested review from diivi and bdougie April 27, 2023 17:51
@diivi
Copy link
Contributor

diivi commented Apr 27, 2023

I'd prefer an unsquashed commit history with just 2 commits - one for the config changes and one for formatting. This is the general convention for formatting changes, so it's easier to see what was changed. Also, consider adding the commit where the code formatter actually runs to .git-blame-ignore-revs

@Anush008
Copy link
Member Author

I'd prefer an unsquashed commit history with just 2 commits - one for the config changes and one for formatting. This is the general convention for formatting changes, so it's easier to see what was changed. Also, consider adding the commit where the code formatter actually runs to .git-blame-ignore-revs

Right. I'll try doing that.

@Anush008
Copy link
Member Author

@diivi, I've overwritten some changes that can't be undone in my local. I'll re-open the PR with your suggested changes.

@Anush008 Anush008 closed this Apr 27, 2023
@bdougie
Copy link
Member

bdougie commented Apr 28, 2023

@diivi, I've overwritten some changes that can't be undone in my local. I'll re-open the PR with your suggested changes.

Anything is possible to unwrite with git reflog. Just for a note for the future.

@Anush008 Anush008 deleted the feat-add-eslint branch April 29, 2023 09:47
@Anush008 Anush008 mentioned this pull request Apr 29, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants