refactor: Refactored inviteToOpenSauced.ts to avoid "as" and "!"

open-sauced · Apr 27, 2023 · 0eb064d · 0eb064d
1 parent 93e741a
commit 0eb064d
Showing 1 changed file with 24 additions and 9 deletions.
diff --git a/src/utils/dom-utils/inviteToOpenSauced.ts b/src/utils/dom-utils/inviteToOpenSauced.ts
@@ -4,15 +4,30 @@ import { InviteToOpenSaucedModal } from "../../content-scripts/components/Invite
 import { getTwitterUsername, getLinkedInUsername } from "../urlMatchers";
 
 const injectOpenSaucedInviteButton = (username: string) => {
-  const emailAddress: string | undefined = (
-    document.querySelector(`a[href^="mailto:"]`)!
-  ).href.substr(7);
-  const twitterUrl: string | undefined = (
-    document.querySelector(`a[href*="twitter.com"]`)!
-  ).href;
-  const linkedInUrl: string | undefined = (
-    document.querySelector(`a[href*="linkedin.com"]`)!
-  ).href;
+  const emailAddress: string | undefined = (() => {
+    const element = document.querySelector(`a[href^="mailto:"]`);
+
+    if (element instanceof HTMLAnchorElement) {
+      return element.href;
+    }
+    return undefined;
+  })();
+  const twitterUrl: string | undefined = (() => {
+    const element = document.querySelector(`a[href*="twitter.com"]`);
+
+    if (element instanceof HTMLAnchorElement) {
+      return element.href;
+    }
+    return undefined;
+  })();
+  const linkedInUrl: string | undefined = (() => {
+    const element = document.querySelector(`a[href*="linkedin.com"]`);
+
+    if (element instanceof HTMLAnchorElement) {
+      return element.href;
+    }
+    return undefined;
+  })();
 
   if (!(emailAddress || twitterUrl || linkedInUrl)) {
     return;