fix: Linting error fix

open-sauced · Apr 27, 2023 · bcd1f47 · bcd1f47
1 parent c175343
commit bcd1f47
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/src/utils/dom-utils/inviteToOpenSauced.ts b/src/utils/dom-utils/inviteToOpenSauced.ts
@@ -44,7 +44,7 @@ const injectOpenSaucedInviteButton = (username: string) => {
 
   const userBio = document.querySelector(GITHUB_PROFILE_MENU_SELECTOR);
 
-  if (!userBio || !userBio.parentNode) {
+  if (!(userBio?.parentNode)) {
     return;
   }
   userBio.parentNode.replaceChild(inviteToOpenSaucedButton, userBio);

diff --git a/src/utils/dom-utils/viewOnOpenSauced.ts b/src/utils/dom-utils/viewOnOpenSauced.ts
@@ -8,7 +8,7 @@ const injectViewOnOpenSaucedButton = (username: string) => {
     `${GITHUB_PROFILE_MENU_SELECTOR}, ${GITHUB_PROFILE_EDIT_MENU_SELECTOR}`,
   );
 
-  if (!userBio || !userBio.parentNode) {
+  if (!(userBio?.parentNode)) {
     return;
   }
   userBio.parentNode.replaceChild(viewOnOpenSaucedButton, userBio);

diff --git a/src/utils/fetchOpenSaucedApiData.ts b/src/utils/fetchOpenSaucedApiData.ts
@@ -28,25 +28,25 @@ export const checkTokenValidity = async (token: string) => {
 };
 
 export const getUserData = async (userName: string, forceRefresh: boolean = false) => cachedFetch(`${OPEN_SAUCED_USERS_ENDPOINT}/${userName}`, {
-  expireInSeconds: 2 * 60 * 60, // 2 hours
+  expireInSeconds: 2 * 60 * 60,
   forceRefresh,
   headers: { Accept: "application/json" },
 }).then(async resp => {
-  if (!resp.ok) {
+  if (!resp?.ok) {
     console.log("error getting user info");
   }
-  return resp.json();
+  return resp?.json();
 })
   .then(json => json);
 
 export const getUserPRData = async (userName: string, forceRefresh: boolean = false) => cachedFetch(`${OPEN_SAUCED_USERS_ENDPOINT}/${userName}/prs`, {
-  expireInSeconds: 2 * 60 * 60, // 2 hours
+  expireInSeconds: 2 * 60 * 60,
   forceRefresh,
   headers: { Accept: "application/json" },
 }).then(async resp => {
-  if (!resp.ok) {
+  if (!resp?.ok) {
     console.log("error getting user PR info");
   }
-  return resp.json();
+  return resp?.json();
 })
   .then(json => json);