-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: rename metrics and service #730
Merged
Kavindu-Dodan
merged 1 commit into
open-feature:main
from
Kavindu-Dodan:feat/rename-metrics-to-semconv
Jul 5, 2023
Merged
feat!: rename metrics and service #730
Kavindu-Dodan
merged 1 commit into
open-feature:main
from
Kavindu-Dodan:feat/rename-metrics-to-semconv
Jul 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kavindu-Dodan
force-pushed
the
feat/rename-metrics-to-semconv
branch
from
July 4, 2023 20:18
9d2aba1
to
f55af69
Compare
Codecov Report
@@ Coverage Diff @@
## main #730 +/- ##
==========================================
+ Coverage 73.68% 73.72% +0.04%
==========================================
Files 26 26
Lines 2603 2607 +4
==========================================
+ Hits 1918 1922 +4
Misses 612 612
Partials 73 73
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
thisthat
approved these changes
Jul 5, 2023
toddbaert
changed the title
feat!: rename metrics and service
feat!: rename metrics and servicee
Jul 5, 2023
toddbaert
changed the title
feat!: rename metrics and servicee
feat!: rename metrics and service
Jul 5, 2023
toddbaert
approved these changes
Jul 5, 2023
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Kavindu-Dodan
force-pushed
the
feat/rename-metrics-to-semconv
branch
from
July 5, 2023 16:57
ee76343
to
f2f9465
Compare
Merged
beeme1mr
pushed a commit
that referenced
this pull request
Jul 14, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.6.0</summary> ## [0.6.0](flagd/v0.5.4...flagd/v0.6.0) (2023-07-13) ### ⚠ BREAKING CHANGES * rename metrics and service ([#730](#730)) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.5.4 ([#693](#693)) ([33705a6](33705a6)) * **deps:** update module github.com/open-feature/go-sdk-contrib/providers/flagd to v0.1.13 ([#697](#697)) ([435448f](435448f)) * **deps:** update module github.com/spf13/viper to v1.16.0 ([#679](#679)) ([798a975](798a975)) ### 🔄 Refactoring * **flagd:** update build.Dockerfile with buildkit caching ([#724](#724)) ([3e9cc1a](3e9cc1a)) * **flagd:** update profile.Dockerfile with buildkit caching ([#723](#723)) ([3f263c6](3f263c6)) * remove protobuf dependency from eval package ([#701](#701)) ([34ffafd](34ffafd)) </details> <details><summary>flagd-proxy: 0.2.5</summary> ## [0.2.5](flagd-proxy/v0.2.4...flagd-proxy/v0.2.5) (2023-07-13) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.5.4 ([#693](#693)) ([33705a6](33705a6)) * **deps:** update module github.com/spf13/viper to v1.16.0 ([#679](#679)) ([798a975](798a975)) ### 🔄 Refactoring * **flagd-proxy:** update build.Dockerfile with buildkit caching ([#725](#725)) ([06f3d2e](06f3d2e)) * remove protobuf dependency from eval package ([#701](#701)) ([34ffafd](34ffafd)) </details> <details><summary>core: 0.6.0</summary> ## [0.6.0](core/v0.5.4...core/v0.6.0) (2023-07-13) ### ⚠ BREAKING CHANGES * rename metrics and service ([#730](#730)) ### 🔄 Refactoring * remove protobuf dependency from eval package ([#701](#701)) ([34ffafd](34ffafd)) ### 🐛 Bug Fixes * **deps:** update kubernetes packages to v0.27.3 ([#708](#708)) ([5bf3a69](5bf3a69)) * **deps:** update module github.com/bufbuild/connect-go to v1.9.0 ([#722](#722)) ([75223e2](75223e2)) * **deps:** update module github.com/bufbuild/connect-opentelemetry-go to v0.4.0 ([#739](#739)) ([713e2a9](713e2a9)) * **deps:** update module github.com/prometheus/client_golang to v1.16.0 ([#709](#709)) ([b8bedd2](b8bedd2)) * **deps:** update module golang.org/x/crypto to v0.10.0 ([#647](#647)) ([7f1d7e6](7f1d7e6)) * **deps:** update module golang.org/x/mod to v0.11.0 ([#705](#705)) ([42813be](42813be)) * **deps:** update module golang.org/x/mod to v0.12.0 ([#729](#729)) ([7b109c7](7b109c7)) * **deps:** update module golang.org/x/net to v0.11.0 ([#706](#706)) ([27d893f](27d893f)) * **deps:** update module golang.org/x/sync to v0.3.0 ([#707](#707)) ([7852efb](7852efb)) * **deps:** update module google.golang.org/grpc to v1.56.1 ([#710](#710)) ([8f16573](8f16573)) * **deps:** update module google.golang.org/grpc to v1.56.2 ([#738](#738)) ([521cc30](521cc30)) * **deps:** update module google.golang.org/protobuf to v1.31.0 ([#720](#720)) ([247239e](247239e)) * **deps:** update opentelemetry-go monorepo ([#648](#648)) ([c12dad8](c12dad8)) ### ✨ New Features * **flagD:** support zero downtime during upgrades ([#731](#731)) ([7df8d39](7df8d39)) * rename metrics and service ([#730](#730)) ([09c0198](09c0198)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: Kavindu Dodanduwa <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kavindu Dodanduwa <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes #712
Refer the following table for metrics renames and their units,
Validation
This change was validated against an OTel setup. Consider following screen captures,