Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove protobuf dependency from eval package #701

Merged
merged 24 commits into from
Jun 21, 2023
Merged

refactor: remove protobuf dependency from eval package #701

merged 24 commits into from
Jun 21, 2023

Conversation

james-milligan
Copy link
Contributor

This PR

  • removes the protobuf dependency from the eval package, handing the structpb.Struct to map[string]any conversion in the handlers package where it is more appropriate

Related Issues

Notes

Follow-up Tasks

How to test

james-milligan and others added 23 commits April 14, 2023 11:03
@james-milligan
extend linting
5a0789f 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
fix linting gci
a3395de 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
linting fix durationcheck
a9c874f 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
linting fix wrapcheck
94c5c27 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
remove ireturn
781fe12 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
linting fix nilerr
86c494c 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
linting fix exhaustive
e816f6c 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
ignore contextcheck in sync store (requires stored context)
5fdf854 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
linting fixes
60a2cd8 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
linting fixes wrapcheck
d0f6e26 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
Merge branch 'main' into linting
70a3a56
@james-milligan
extend timeout
960bed4 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
Merge branch 'linting' of https://github.com/james-milligan/flagd int…
562461d 
…o linting
@james-milligan
Merge branch 'main' into linting
0f8865e
@james-milligan
merge
72f4519 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
cleanup
1d1c69a 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
Merge branch 'linting' of https://github.com/james-milligan/flagd int…
cc7b1ea 
…o linting
@james-milligan
removed duplicated import
fde4853 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
linting fixes
ec5a10c 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
remove protobuf dependency from eval
94c6d7e 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
linting
6440447 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
merge conflicts
3c14295 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
conflicts fix
a99ff39 
Signed-off-by: James Milligan <[email protected]>
@james-milligan james-milligan requested a review from a team as a code owner June 14, 2023 11:56
@codecov
Copy link

codecov bot commented Jun 14, 2023 •
edited
Loading

Codecov Report

Merging #701 (4cbb4a7) into main (56df71a) will decrease coverage by 0.10%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main     #701      +/-   ##
==========================================
- Coverage   73.77%   73.68%   -0.10%     
==========================================
  Files          26       26              
  Lines        2601     2603       +2     
==========================================
- Hits         1919     1918       -1     
- Misses        610      612       +2     
- Partials       72       73       +1
Impacted Files Coverage Δ
core/pkg/eval/ievaluator.go 100.00% <ø> (ø)
core/pkg/service/flag-evaluation/flag_evaluator.go 77.15% <50.00%> (-1.11%) ⬇️
core/pkg/eval/json_evaluator.go 88.72% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@beeme1mr beeme1mr merged commit 34ffafd into open-feature:main Jun 21, 2023
@github-actions github-actions bot mentioned this pull request Jun 21, 2023
Merged
beeme1mr pushed a commit that referenced this pull request Jul 14, 2023
@github-actions @Kavindu-Dodan
chore: release main (#694)
dbf7d2b 
🤖 I have created a release *beep* *boop*
---


<details><summary>flagd: 0.6.0</summary>

##
[0.6.0](flagd/v0.5.4...flagd/v0.6.0)
(2023-07-13)

### ⚠ BREAKING CHANGES

* rename metrics and service
([#730](#730))

### 🐛 Bug Fixes

* **deps:** update module github.com/open-feature/flagd/core to v0.5.4
([#693](#693))
([33705a6](33705a6))
* **deps:** update module
github.com/open-feature/go-sdk-contrib/providers/flagd to v0.1.13
([#697](#697))
([435448f](435448f))
* **deps:** update module github.com/spf13/viper to v1.16.0
([#679](#679))
([798a975](798a975))


### 🔄 Refactoring

* **flagd:** update build.Dockerfile with buildkit caching
([#724](#724))
([3e9cc1a](3e9cc1a))
* **flagd:** update profile.Dockerfile with buildkit caching
([#723](#723))
([3f263c6](3f263c6))
* remove protobuf dependency from eval package
([#701](#701))
([34ffafd](34ffafd))
</details>

<details><summary>flagd-proxy: 0.2.5</summary>

##
[0.2.5](flagd-proxy/v0.2.4...flagd-proxy/v0.2.5)
(2023-07-13)


### 🐛 Bug Fixes

* **deps:** update module github.com/open-feature/flagd/core to v0.5.4
([#693](#693))
([33705a6](33705a6))
* **deps:** update module github.com/spf13/viper to v1.16.0
([#679](#679))
([798a975](798a975))


### 🔄 Refactoring

* **flagd-proxy:** update build.Dockerfile with buildkit caching
([#725](#725))
([06f3d2e](06f3d2e))
* remove protobuf dependency from eval package
([#701](#701))
([34ffafd](34ffafd))
</details>

<details><summary>core: 0.6.0</summary>

##
[0.6.0](core/v0.5.4...core/v0.6.0)
(2023-07-13)


### ⚠ BREAKING CHANGES

* rename metrics and service
([#730](#730))

### 🔄 Refactoring

* remove protobuf dependency from eval package
([#701](#701))
([34ffafd](34ffafd))


### 🐛 Bug Fixes

* **deps:** update kubernetes packages to v0.27.3
([#708](#708))
([5bf3a69](5bf3a69))
* **deps:** update module github.com/bufbuild/connect-go to v1.9.0
([#722](#722))
([75223e2](75223e2))
* **deps:** update module github.com/bufbuild/connect-opentelemetry-go
to v0.4.0 ([#739](#739))
([713e2a9](713e2a9))
* **deps:** update module github.com/prometheus/client_golang to v1.16.0
([#709](#709))
([b8bedd2](b8bedd2))
* **deps:** update module golang.org/x/crypto to v0.10.0
([#647](#647))
([7f1d7e6](7f1d7e6))
* **deps:** update module golang.org/x/mod to v0.11.0
([#705](#705))
([42813be](42813be))
* **deps:** update module golang.org/x/mod to v0.12.0
([#729](#729))
([7b109c7](7b109c7))
* **deps:** update module golang.org/x/net to v0.11.0
([#706](#706))
([27d893f](27d893f))
* **deps:** update module golang.org/x/sync to v0.3.0
([#707](#707))
([7852efb](7852efb))
* **deps:** update module google.golang.org/grpc to v1.56.1
([#710](#710))
([8f16573](8f16573))
* **deps:** update module google.golang.org/grpc to v1.56.2
([#738](#738))
([521cc30](521cc30))
* **deps:** update module google.golang.org/protobuf to v1.31.0
([#720](#720))
([247239e](247239e))
* **deps:** update opentelemetry-go monorepo
([#648](#648))
([c12dad8](c12dad8))


### ✨ New Features

* **flagD:** support zero downtime during upgrades
([#731](#731))
([7df8d39](7df8d39))
* rename metrics and service
([#730](#730))
([09c0198](09c0198))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: Kavindu Dodanduwa <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kavindu Dodanduwa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@james-milligan @beeme1mr @Kavindu-Dodan