Switch .deb package publishing to S3 #314
Conversation
| def lock(self, conf, baseuri): | ||
| """Rename semaphore file""" | ||
| print(f"Locking {baseuri} ...") | ||
| cmd = f"s3cmd mv --no-progress {baseuri}/.debrepos3.nolock {baseuri}/.debrepos3.lock" |
There was a problem hiding this comment.
Be careful that the mv operation is not atomic on s3 and is basically equivalent to doing a copy and delete. It might still be enough to prevent race conditions on the CI which has high latency, but it's probably worth noting this caveat in the code to prevent surprises down the line.
There was a problem hiding this comment.
The copy + delete process should implement something similar to a 2-step lock: during the interval when both files exist other attempt at copy should fail.
|
Thank you, @FedericoCeratto! I will look into merging this package after 3.10.0-beta is out. (In 3.10.0-beta we fix a bunch of Android-related issues and, once that is done, we can prepare 3.10.0's |
This diff implements part of the release checklist at ooni/probe#1439. The plan is to bless a beta release and use it for further testing on Android devices. Afterward, we need to apply some extra changes to the `cli` (including #314 and #312). Finally, we will bless a full 3.10.0 release.
|
Not merged yet because it seems we still have some issues with the bucket. |
This diff implements part of the release checklist at ooni/probe#1439. The plan is to bless a beta release and use it for further testing on Android devices. Afterward, we need to apply some extra changes to the `cli` (including ooni#314 and ooni#312). Finally, we will bless a full 3.10.0 release.
This PR switches the` .deb` package publishing to s3 because Bintray has been shut down.
WIP