Add support for tracking the is_uploaded status in the results table #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add unit tests for measurement upload status This implements: ooni/probe#1457
|
👀 Thank you! I will review and merge this diff after 3.10.0-beta is out. (With 3.10.0-beta, we aim to solve ooni/probe#1444, which is an Android-only issue; with that fixed, we can then focus on probe-cli and integrate this diff.) |
bassosimone
added a commit
that referenced
this pull request
Apr 28, 2021
This diff implements part of the release checklist at ooni/probe#1439. The plan is to bless a beta release and use it for further testing on Android devices. Afterward, we need to apply some extra changes to the `cli` (including #314 and #312). Finally, we will bless a full 3.10.0 release.
bassosimone
reviewed
Apr 30, 2021
bassosimone
reviewed
Apr 30, 2021
| @@ -57,7 +57,7 @@ func GetMeasurementJSON(sess sqlbuilder.Database, measurementID int64) (map[stri | |||
| log.Errorf("failed to run query %s: %v", req.String(), err) | |||
| return nil, err | |||
| } | |||
| if measurement.IsUploaded { | |||
| if measurement.Measurement.IsUploaded { | |||
There was a problem hiding this comment.
Now both Measurement and Result have IsUploaded. To disambiguate we need to explicitly specify that we want to select the IsUploaded attribute of the Measurement.
ainghazal
pushed a commit
to ainghazal/probe-cli
that referenced
this pull request
Mar 8, 2022
This diff implements part of the release checklist at ooni/probe#1439. The plan is to bless a beta release and use it for further testing on Android devices. Afterward, we need to apply some extra changes to the `cli` (including ooni#314 and ooni#312). Finally, we will bless a full 3.10.0 release.
ainghazal
pushed a commit
to ainghazal/probe-cli
that referenced
this pull request
Mar 8, 2022
…oni#312) * Add support for tracking the is_uploaded status in the results table * Add unit tests for measurement upload status This implements: ooni/probe#1457 * Update cmd/ooniprobe/internal/database/actions.go Co-authored-by: Simone Basso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements: ooni/probe#1457