Start preparing release 3.10.0 beta #313
Conversation
Bintray is gone, so we cannot publish an Android release. By removing this part of the Android build process we are going to ensure Android CI builds complete successfully. This is a failed build: https://github.com/ooni/probe-cli/pull/313/checks?check_run_id=2438302064#step:8:7 As you can see, the failure here is that the file name is not the correct file name anymore. I could fix that, but still the code would not be able to upload anyway. Bintray is shutting down. So, I have chosen to just remove the upload script. Part of ooni/probe#1439.
So we need to fake the version number. It's fine for it to be the SHA as long as we're just making a temporary build. Since bintray is gone, there is no point for now in making more than just a temporary build at github actions. Part of ooni/probe#1439
Bintray is gone. Let's not even try publishing an iOS release using bintray because that's not gonna work. Part of ooni/probe#1439
This would make Android/iOS builds fail while we're working to make all workflows green in ooni/probe#1439
|
The only failed test is in the swagger (see https://github.com/ooni/probe-cli/pull/313/checks?check_run_id=2449042594). I will address this failure at a later stage when I'm blessing the real 3.10.0. We can merge this PR now, which moves us one step closer to have another mobile build with the proxy functionality to continue to test. |
| @@ -19,6 +19,3 @@ jobs: | |||
| - run: ./build-android.bash | |||
| env: | |||
| ANDROID_HOME: /usr/local/Caskroom/android-sdk/4333796 | |||
| - run: ./publish-android.bash | |||
| env: | |||
| MOBILE_BINTRAY_API_KEY: ${{ secrets.MOBILE_BINTRAY_API_KEY }} | |||
There was a problem hiding this comment.
This fixes the failing android workflow: the script has been removed and Bintray is gone.
| @@ -13,6 +13,3 @@ jobs: | |||
| go-version: "1.16" | |||
| - uses: actions/checkout@v2 | |||
| - run: ./build-ios.bash | |||
| - run: ./publish-ios.bash | |||
| env: | |||
| MOBILE_BINTRAY_API_KEY: ${{ secrets.MOBILE_BINTRAY_API_KEY }} | |||
There was a problem hiding this comment.
This fixes the failing ios workflow: the script has been removed, and Bintray is gone.
| @@ -7,7 +7,7 @@ go get -u golang.org/x/mobile/cmd/gomobile | |||
| gomobile init | |||
| output=MOBILE/ios/oonimkall.framework | |||
| gomobile bind -target=ios -o $output -ldflags="-s -w" ./pkg/oonimkall | |||
| release=$(git describe --tags) | |||
| release=$(git describe --tags || echo $GITHUB_SHA) | |||
There was a problem hiding this comment.
We don't have git inside GitHub actions. We are currently not publishing packages, so it's fine for us to use the GITHUB_SHA environment variable for now.
| github.com/ooni/probe-assets v0.0.0-20210401100648-90ed7b6dff90 | ||
| github.com/ooni/psiphon v0.6.0 | ||
| github.com/montanaflynn/stats v0.6.6 | ||
| github.com/ooni/probe-assets v0.2.0 |
There was a problem hiding this comment.
We are now using semver for ooni/probe-assets. Not using it broke go get -u -v ./....
This diff implements part of the release checklist at ooni/probe#1439. The plan is to bless a beta release and use it for further testing on Android devices. Afterward, we need to apply some extra changes to the `cli` (including ooni#314 and ooni#312). Finally, we will bless a full 3.10.0 release.
This pull request starts preparing release 3.10.0-beta. The idea here is to prepare a 3.10.0-beta release to test on mobile and desktop and bless 3.10.0 after a few days of testing. For preparing this beta release, we will chain more than one PR. We want, for example, to include #311 into the beta release.