Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

channel settings ui refactoring, styling & bugfixing/improvements #58

Merged
merged 30 commits into from
May 11, 2017

Conversation

waxenegger
Copy link
Member

@waxenegger waxenegger commented May 3, 2017

see: ome/design#75

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build iviewer-merge#263. See the console output for more details.
Possible conflicts:

@will-moore
Copy link
Member

Pushed some more commits to #59 for cherry-picking.

@waxenegger waxenegger changed the title channel settings ui refactoring and styling channel settings ui refactoring, styling & bugfixing/improvements May 11, 2017
@jburel
Copy link
Member

jburel commented May 11, 2017

Selection in table/switch mode works. This is better I think

@jburel
Copy link
Member

jburel commented May 11, 2017

Could you add copyright in the various javascript files modified in this PR?

@will-moore
Copy link
Member

All seems to be looking good and working fine for me.

@jburel
Copy link
Member

jburel commented May 11, 2017

Merging
We can add copyright in js file in a follow up PR.

@jburel jburel merged commit d91f08d into ome:master May 11, 2017
@waxenegger waxenegger deleted the channel_settings_style branch May 15, 2017 01:23
@jburel jburel modified the milestone: 0.1.0 May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants