-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iViewer UI #75
Comments
scale bar location has been raised as a problem so we should try to keep it in the "bottom-left corner" of the image not the viewport |
To avoid confusion, User settings with the list of thumbnails will still be displayed in "settings" |
Discussed today: look into making the scalebar draggable |
Should the dataset image side panel on the left still be resizable/collapsible? |
@jburel and @will-moore Is the only way to turn off rois the checkbox on the header of the table.... This is going to be a bit of a technical nightmare, the reason being that instead of being able to turn off the vector layer altogether in ol3, I keep it on but make all shapes "invisible" (by tricking ol3 with filtering). Essentially all the workflow and code paths will be still active. Originally the visibility was more a means to turn off individual shapes, for hiding the rois altogether it's not a great solution but will be one that's inevitable if we still show the table and allow for some actions. There are various events in place to guarantee that after some action such as selection or any modification the state of the shapes are sync with the embedded ol3 viewer. Now what that means is that I cannot allow for certain actions such as delete or modify or copy and paste or attachment locks without having the vector layer on. shapes or features as their counterpart in ol3 are inextricably linked to the vector layer and that makes good sense because without that layer there is no means of working with them. So if we plan on showing the table while every shape in it is not visible to the user allowing for some actions on invisible rois, the only one that really makes sense to me being delete, not sure of copy & pasting and modifying invisible shapes....then I'm going to have to disable some actions at a minimum. Another thing is that the columns of the roi table are actually resizable and the checkbox can be pushed over. |
As discussed, unchecking the Show in table header will simply hide every shape in the viewer but you can still interact with them in the table, delete them etc. If a user draws a new shape it will be visible and the header Show will become checked (same as if user manually checks Show on one or more shapes). |
That is not what is currently implemented. |
For any measurements we will need units and maybe ability to switch between for example pixels and microns |
Export intensities in the ROI to somewhere - is that planned to be in a new tab ? |
Idea is to export measurement as csv |
@jburel : Agreed. I was just thinking about where the export button would live. |
We will also need a way to trigger the analysis of the selected shapes |
Probably add an "Export/Download" button beside the Save/Undo/Redo buttons at the top. |
@will-moore : Intensities ? You mean to show average intensity per ROI ? You would not have a space for showing even all intensities from relatively small ROIs ? |
Export might be more suitable since we were thinking of having a Download button on the info tab |
Some proposed cleanup & future feature prototyping for iViewer.
Generally aiming to reduce 'ink' on the page to give a cleaner look.
cc @waxenegger @jburel
The text was updated successfully, but these errors were encountered: