Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OL3 style changes for controls (esp. zoom) #56

Merged
merged 8 commits into from
May 4, 2017

Conversation

waxenegger
Copy link
Member

@waxenegger waxenegger commented Apr 28, 2017

see: ome/design#75

If there are any requests for style changes, please be as specific as possible. The css colors and styles I cannot really fully deduce from looking at the mockups only. So if the there is a preferred style and it is already in the css just point me toward it, if not just give me the color in any notation or the respective css property that should be applied. That way we avoid a guessing and back and forth.

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build iviewer-merge#244. See the console output for more details.
Possible conflicts:

@will-moore
Copy link
Member

Looking good.
It just occurred to me that we could make the controls at top-right appear to match the zoom controls a bit better, having them along the top...
E.g. these changes:

.ol-control button {
    height: 1.85em;
    width: 1.85em;
}
.ol-full-screen {
    right: .85em;
}
.ol-rotate {
    top: 0.5em;
    right: 3.35em;
}
.ol-overviewmap {
    right: .85em;
}

Will give you this:

screen shot 2017-05-03 at 11 16 46

@waxenegger
Copy link
Member Author

@will-moore I have included the css changes mentioned and altered the scalbar style.

There is a 1px margin on .class ol-scale-line-inner still. I think without it contrast is quite low but have a go yourself and remove it to see the results.

@will-moore
Copy link
Member

Here's a slightly different look:

screen shot 2017-05-04 at 10 13 07

screen shot 2017-05-04 at 10 21 33

Maybe even slightly cleaner without any margin (no ambiguity about inner/outer length):

screen shot 2017-05-04 at 10 25 03

.ol-scale-line-inner {
    border-bottom: 6px solid #000;
    /--------remove: border-top: ---------/
    font-size: 12px;
    /------- remove: margin: 1px; --------/
}

@will-moore
Copy link
Member

Other css changes look good.

@jburel
Copy link
Member

jburel commented May 4, 2017

the adjusted scale bar looks nice easier to find an allows to check distance between element

@will-moore
Copy link
Member

Looks good, thanks.

@jburel jburel merged commit cb26dc7 into ome:master May 4, 2017
@waxenegger waxenegger mentioned this pull request May 8, 2017
@waxenegger waxenegger deleted the zoom_styling branch May 15, 2017 01:23
@jburel jburel modified the milestone: 0.1.0 May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants