[FIX] Evaluation: Remove old spreaded cells from spread relations #5225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hokolomopo
reviewed
Nov 18, 2024
rrahir
force-pushed
the
17.0-invalidate-spread-relation-rar
branch
from
0b9b571 to
93adfb2
Compare
Comment on lines
757
to
758
| expect(model.getters.getCorrespondingFormulaCell({ sheetId, ...toCartesian("B1") })).toBe( | ||
| model.getters.getCorrespondingFormulaCell({ sheetId, ...toCartesian("B1") }) |
There was a problem hiding this comment.
I fail to understand the purpose of this assertion 😅 It's comparing the same thing to itself.
Most probably you meant writing something else
There was a problem hiding this comment.
indeed, a bad move. Thankfully, the corrected version also works!
Currently, the spread relations of a spreaded formula are not invalidated. The evaluated value of the relation is currently properly invalidated so it's not posing any problem during the evaluation/display phase but some features rely specifically on the spreading relation (e.g. the pivot cells highlighting in the top bar) and the current situation leads to false positives (see attached test). Task: 4342240
rrahir
force-pushed
the
17.0-invalidate-spread-relation-rar
branch
from
93adfb2 to
a663403
Compare
robodoo
pushed a commit
that referenced
this pull request
Nov 26, 2024
Currently, the spread relations of a spreaded formula are not invalidated. The evaluated value of the relation is currently properly invalidated so it's not posing any problem during the evaluation/display phase but some features rely specifically on the spreading relation (e.g. the pivot cells highlighting in the top bar) and the current situation leads to false positives (see attached test). closes #5225 Task: 4342240 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the spread relations of a spreaded formula are not invalidated. The evaluated value of the relation is currently properly invalidated so it's not posing any problem during the evaluation/display phase but some features rely specifically on the spreading relation (e.g. the pivot cells highlighting in the top bar) and the current situation leads to false positives (see attached test).
Task: 4342240
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist