Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] Evaluation: Remove old spreaded cells from spread relations #5269

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Nov 26, 2024

Currently, the spread relations of a spreaded formula are not invalidated. The evaluated value of the relation is currently properly invalidated so it's not posing any problem during the evaluation/display phase but some features rely specifically on the spreading relation (e.g. the pivot cells highlighting in the top bar) and the current situation leads to false positives (see attached test).

Task: 4342240

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #5225

@robodoo
Copy link
Collaborator

robodoo commented Nov 26, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Nov 26, 2024

@rrahir @LucasLefevre cherrypicking of pull request #5225 failed.

stdout:

Auto-merging src/plugins/ui_core_views/cell_evaluation/evaluator.ts
CONFLICT (content): Merge conflict in src/plugins/ui_core_views/cell_evaluation/evaluator.ts
Auto-merging tests/evaluation/evaluation_formula_array.test.ts
CONFLICT (content): Merge conflict in tests/evaluation/evaluation_formula_array.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Currently, the spread relations of a spreaded formula are not invalidated.
The evaluated value of the relation is currently properly invalidated
so it's not posing any problem during the evaluation/display
phase but some features rely specifically on the spreading relation
(e.g. the pivot cells highlighting in the top bar) and the current
situation leads to false positives (see attached test).

Task: 4342240
X-original-commit: a6f7d40
@rrahir rrahir force-pushed the saas-17.2-17.0-invalidate-spread-relation-rar-f8YA-fw branch from b79c602 to ab48d59 Compare November 28, 2024 07:20
@rrahir
Copy link
Collaborator

rrahir commented Nov 28, 2024

@robodoo r+

robodoo pushed a commit that referenced this pull request Nov 28, 2024
Currently, the spread relations of a spreaded formula are not invalidated.
The evaluated value of the relation is currently properly invalidated
so it's not posing any problem during the evaluation/display
phase but some features rely specifically on the spreading relation
(e.g. the pivot cells highlighting in the top bar) and the current
situation leads to false positives (see attached test).

closes #5269

Task: 4342240
X-original-commit: a6f7d40
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Signed-off-by: Rémi Rahir (rar) <[email protected]>
@robodoo robodoo closed this Nov 28, 2024
@fw-bot fw-bot deleted the saas-17.2-17.0-invalidate-spread-relation-rar-f8YA-fw branch December 12, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants