16.0 fix export formula vsc #3364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentSchippefilt
force-pushed
the
16.0--fix-export-formula-vsc
branch
from
d69117d to
a168455
Compare
|
@robodoo rebase-ff |
|
I'm sorry, @VincentSchippefilt: you can't method=rebase-ff. |
|
@fw-bot up to saas-16.4 |
|
Forward-porting to 'saas-16.4'. |
VincentSchippefilt
force-pushed
the
16.0--fix-export-formula-vsc
branch
2 times, most recently
from
4f7fb11 to
b46b7eb
Compare
VincentSchippefilt
force-pushed
the
16.0--fix-export-formula-vsc
branch
from
b46b7eb to
a7dd7ef
Compare
Before this fix the test "Can instantiate a spreadsheet with a given client id-name" failed frequently on my machine. Using jest's fake timers for those tests (timers are used in the debounce) fixed the issue Task: 3618912
before this commit, the exported formulas contained line returns. It woudn't show properly in google sheet. after this commit, the line returns have been removedd Task: 3618912
VincentSchippefilt
force-pushed
the
16.0--fix-export-formula-vsc
branch
from
35e3f0b to
cc06c59
Compare
Excel does not support unbound references like A3:3 or C3:C. This commit transforms them to A3:XX3 and C3:CXX where XX is the last column or row of the sheet. Task: 3618912
VincentSchippefilt
force-pushed
the
16.0--fix-export-formula-vsc
branch
from
cc06c59 to
74b5e5c
Compare
|
@VincentSchippefilt @LucasLefevre because this PR has multiple commits, I need to know how to merge it:
|
|
robodoo rebase-ff |
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Jan 25, 2024
Before this fix the test "Can instantiate a spreadsheet with a given client id-name" failed frequently on my machine. Using jest's fake timers for those tests (timers are used in the debounce) fixed the issue Task: 3618912 Part-of: #3364
robodoo
pushed a commit
that referenced
this pull request
Jan 25, 2024
before this commit, the exported formulas contained line returns. It woudn't show properly in google sheet. after this commit, the line returns have been removedd Task: 3618912 Part-of: #3364
robodoo
pushed a commit
that referenced
this pull request
Jan 25, 2024
Excel does not support unbound references like A3:3 or C3:C. This commit transforms them to A3:XX3 and C3:CXX where XX is the last column or row of the sheet. closes #3364 Task: 3618912 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
14 tasks
|
@VincentSchippefilt @LucasLefevre this pull request has forward-port PRs awaiting action (not merged or closed): |
14 tasks
|
@VincentSchippefilt @LucasLefevre this pull request has forward-port PRs awaiting action (not merged or closed): |
14 tasks
14 tasks
VincentSchippefilt
added a commit
that referenced
this pull request
Feb 6, 2024
In the PR #3364 I try to fix the export to excel of unbound zones by fixing them. However I have not taken into account the normal expor in spreadsheet that is done when generating snapshot. This fix keeps the unbound zones in snapshots, while convert them into bound zones in excel export.
robodoo
pushed a commit
that referenced
this pull request
Feb 6, 2024
In the PR #3364 I try to fix the export to excel of unbound zones by fixing them. However I have not taken into account the normal expor in spreadsheet that is done when generating snapshot. This fix keeps the unbound zones in snapshots, while convert them into bound zones in excel export. closes #3616 Signed-off-by: Rémi Rahir (rar) <[email protected]> Signed-off-by: Vincent Schippefilt (vsc) <[email protected]>
fw-bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
In the PR #3364 I try to fix the export to excel of unbound zones by fixing them. However I have not taken into account the normal expor in spreadsheet that is done when generating snapshot. This fix keeps the unbound zones in snapshots, while convert them into bound zones in excel export. X-original-commit: 0ed2720
14 tasks
14 tasks
VincentSchippefilt
added a commit
that referenced
this pull request
Feb 6, 2024
In the PR #3364 I try to fix the export to excel of unbound zones by fixing them. However I have not taken into account the normal expor in spreadsheet that is done when generating snapshot. This fix keeps the unbound zones in snapshots, while convert them into bound zones in excel export. X-original-commit: 0ed2720
robodoo
pushed a commit
that referenced
this pull request
Feb 6, 2024
In the PR #3364 I try to fix the export to excel of unbound zones by fixing them. However I have not taken into account the normal expor in spreadsheet that is done when generating snapshot. This fix keeps the unbound zones in snapshots, while convert them into bound zones in excel export. closes #3621 X-original-commit: 0ed2720 Signed-off-by: Rémi Rahir (rar) <[email protected]> Signed-off-by: Vincent Schippefilt (vsc) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Feb 6, 2024
In the PR #3364 I try to fix the export to excel of unbound zones by fixing them. However I have not taken into account the normal expor in spreadsheet that is done when generating snapshot. This fix keeps the unbound zones in snapshots, while convert them into bound zones in excel export. closes #3620 X-original-commit: 0ed2720 Signed-off-by: Rémi Rahir (rar) <[email protected]> Signed-off-by: Vincent Schippefilt (vsc) <[email protected]>
14 tasks
VincentSchippefilt
added a commit
that referenced
this pull request
Feb 6, 2024
In the PR #3364 I try to fix the export to excel of unbound zones by fixing them. However I have not taken into account the normal expor in spreadsheet that is done when generating snapshot. This fix keeps the unbound zones in snapshots, while convert them into bound zones in excel export. X-original-commit: 0ed2720
robodoo
pushed a commit
that referenced
this pull request
Feb 6, 2024
In the PR #3364 I try to fix the export to excel of unbound zones by fixing them. However I have not taken into account the normal expor in spreadsheet that is done when generating snapshot. This fix keeps the unbound zones in snapshots, while convert them into bound zones in excel export. closes #3622 X-original-commit: 0ed2720 Signed-off-by: Rémi Rahir (rar) <[email protected]> Signed-off-by: Vincent Schippefilt (vsc) <[email protected]>
14 tasks
VincentSchippefilt
added a commit
that referenced
this pull request
Feb 6, 2024
In the PR #3364 I try to fix the export to excel of unbound zones by fixing them. However I have not taken into account the normal expor in spreadsheet that is done when generating snapshot. This fix keeps the unbound zones in snapshots, while convert them into bound zones in excel export. X-original-commit: 0ed2720
robodoo
pushed a commit
that referenced
this pull request
Feb 6, 2024
In the PR #3364 I try to fix the export to excel of unbound zones by fixing them. However I have not taken into account the normal expor in spreadsheet that is done when generating snapshot. This fix keeps the unbound zones in snapshots, while convert them into bound zones in excel export. closes #3623 X-original-commit: 0ed2720 Signed-off-by: Rémi Rahir (rar) <[email protected]> Signed-off-by: Vincent Schippefilt (vsc) <[email protected]>
14 tasks
VincentSchippefilt
added a commit
that referenced
this pull request
Feb 6, 2024
In the PR #3364 I try to fix the export to excel of unbound zones by fixing them. However I have not taken into account the normal expor in spreadsheet that is done when generating snapshot. This fix keeps the unbound zones in snapshots, while convert them into bound zones in excel export. X-original-commit: 201aea7
robodoo
pushed a commit
that referenced
this pull request
Feb 6, 2024
In the PR #3364 I try to fix the export to excel of unbound zones by fixing them. However I have not taken into account the normal expor in spreadsheet that is done when generating snapshot. This fix keeps the unbound zones in snapshots, while convert them into bound zones in excel export. closes #3625 X-original-commit: 201aea7 Signed-off-by: Rémi Rahir (rar) <[email protected]> Signed-off-by: Vincent Schippefilt (vsc) <[email protected]>
14 tasks
VincentSchippefilt
added a commit
that referenced
this pull request
Feb 7, 2024
In the PR #3364 I try to fix the export to excel of unbound zones by fixing them. However I have not taken into account the normal expor in spreadsheet that is done when generating snapshot. This fix keeps the unbound zones in snapshots, while convert them into bound zones in excel export. X-original-commit: aed5b96
robodoo
pushed a commit
that referenced
this pull request
Feb 7, 2024
In the PR #3364 I try to fix the export to excel of unbound zones by fixing them. However I have not taken into account the normal expor in spreadsheet that is done when generating snapshot. This fix keeps the unbound zones in snapshots, while convert them into bound zones in excel export. closes #3626 X-original-commit: aed5b96 Signed-off-by: Rémi Rahir (rar) <[email protected]> Signed-off-by: Vincent Schippefilt (vsc) <[email protected]>
Topdev97
added a commit
to Topdev97/o-spreadsheet
that referenced
this pull request
Nov 18, 2024
In the PR odoo/o-spreadsheet#3364 I try to fix the export to excel of unbound zones by fixing them. However I have not taken into account the normal expor in spreadsheet that is done when generating snapshot. This fix keeps the unbound zones in snapshots, while convert them into bound zones in excel export. closes odoo/o-spreadsheet#3616 Signed-off-by: Rémi Rahir (rar) <[email protected]> Signed-off-by: Vincent Schippefilt (vsc) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: : 3618912
review checklist