Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] export: unbound formula stays unbound in snapshots #3625

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Feb 6, 2024

In the PR #3364 I try to fix the export to excel of unbound zones by fixing them. However I have not taken into account the normal expor in spreadsheet that is done when generating snapshot.

This fix keeps the unbound zones in snapshots, while convert them into bound zones in excel export.

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3623
Forward-Port-Of: #3614

@robodoo
Copy link
Collaborator

robodoo commented Feb 6, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Feb 6, 2024

This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot
Copy link
Collaborator Author

fw-bot commented Feb 6, 2024

@VincentSchippefilt @rrahir ci/runbot failed on this forward-port PR

In the PR #3364 I try to
fix the export to excel of unbound zones by fixing them. However I have
not taken into account the normal expor in spreadsheet that is done when
generating snapshot.

This fix keeps the unbound zones in snapshots, while convert them into
bound zones in excel export.

X-original-commit: 201aea7
@VincentSchippefilt VincentSchippefilt force-pushed the saas-17.1-16.0-fix-export-formula-vsc-puif-fw branch from 2c6ff45 to 0b0e878 Compare February 6, 2024 14:57
@VincentSchippefilt
Copy link
Collaborator

robodoo r+

@fw-bot
Copy link
Collaborator Author

fw-bot commented Feb 6, 2024

@VincentSchippefilt @rrahir this PR was modified / updated and has become a normal PR. It should be merged the normal way (via @robodoo)

robodoo pushed a commit that referenced this pull request Feb 6, 2024
In the PR #3364 I try to
fix the export to excel of unbound zones by fixing them. However I have
not taken into account the normal expor in spreadsheet that is done when
generating snapshot.

This fix keeps the unbound zones in snapshots, while convert them into
bound zones in excel export.

closes #3625

X-original-commit: 201aea7
Signed-off-by: Rémi Rahir (rar) <[email protected]>
Signed-off-by: Vincent Schippefilt (vsc) <[email protected]>
@robodoo robodoo closed this Feb 6, 2024
@fw-bot fw-bot deleted the saas-17.1-16.0-fix-export-formula-vsc-puif-fw branch February 20, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants