Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW] 16.0 fix export formula vsc #3566

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jan 30, 2024

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : 3618912

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3561
Forward-Port-Of: #3364

@robodoo
Copy link
Collaborator

robodoo commented Jan 30, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jan 30, 2024

@VincentSchippefilt @LucasLefevre cherrypicking of pull request #3364 failed.

stdout:

Auto-merging src/helpers/misc.ts
Auto-merging tests/components/spreadsheet.test.ts
CONFLICT (content): Merge conflict in tests/components/spreadsheet.test.ts

stderr:

08:54:46.369765 git.c:463               trace: built-in: git cherry-pick 63a258eec664a73154b5dc4bab818513e071b7a8
error: could not apply 63a258eec... [FIX] test: undeterministic test in spreadsheet.test.ts
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Before this fix the test "Can instantiate a spreadsheet with a given client id-name"
failed frequently on my machine.

Using jest's fake timers for those tests (timers are used in the debounce) fixed the issue

Task: 3618912
before this commit, the exported formulas contained line returns. It woudn't show properly in google sheet.

after this commit, the line returns have been removedd

Task: 3618912
Excel does not support unbound references like A3:3 or C3:C.
This commit transforms them to A3:XX3 and C3:CXX where XX is the
last column or row of the sheet.

Task: 3618912
@VincentSchippefilt VincentSchippefilt force-pushed the saas-16.3-16.0--fix-export-formula-vsc-DUN4-fw branch from deb0b59 to 7b9d53a Compare January 30, 2024 08:12
@VincentSchippefilt
Copy link
Collaborator

robodoo r+

robodoo pushed a commit that referenced this pull request Jan 30, 2024
Before this fix the test "Can instantiate a spreadsheet with a given client id-name"
failed frequently on my machine.

Using jest's fake timers for those tests (timers are used in the debounce) fixed the issue

Task: 3618912
Part-of: #3566
robodoo pushed a commit that referenced this pull request Jan 30, 2024
before this commit, the exported formulas contained line returns. It woudn't show properly in google sheet.

after this commit, the line returns have been removedd

Task: 3618912
Part-of: #3566
robodoo pushed a commit that referenced this pull request Jan 30, 2024
Excel does not support unbound references like A3:3 or C3:C.
This commit transforms them to A3:XX3 and C3:CXX where XX is the
last column or row of the sheet.

closes #3566

Task: 3618912
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Signed-off-by: Vincent Schippefilt (vsc) <[email protected]>
@robodoo robodoo closed this Jan 30, 2024
@fw-bot fw-bot mentioned this pull request Jan 30, 2024
14 tasks
@fw-bot fw-bot deleted the saas-16.3-16.0--fix-export-formula-vsc-DUN4-fw branch February 13, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants