-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FW] 16.0 fix export formula vsc #3566
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@VincentSchippefilt @LucasLefevre cherrypicking of pull request #3364 failed. stdout:
stderr:
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Before this fix the test "Can instantiate a spreadsheet with a given client id-name" failed frequently on my machine. Using jest's fake timers for those tests (timers are used in the debounce) fixed the issue Task: 3618912
before this commit, the exported formulas contained line returns. It woudn't show properly in google sheet. after this commit, the line returns have been removedd Task: 3618912
Excel does not support unbound references like A3:3 or C3:C. This commit transforms them to A3:XX3 and C3:CXX where XX is the last column or row of the sheet. Task: 3618912
VincentSchippefilt
force-pushed
the
saas-16.3-16.0--fix-export-formula-vsc-DUN4-fw
branch
from
January 30, 2024 08:12
deb0b59
to
7b9d53a
Compare
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jan 30, 2024
Before this fix the test "Can instantiate a spreadsheet with a given client id-name" failed frequently on my machine. Using jest's fake timers for those tests (timers are used in the debounce) fixed the issue Task: 3618912 Part-of: #3566
robodoo
pushed a commit
that referenced
this pull request
Jan 30, 2024
before this commit, the exported formulas contained line returns. It woudn't show properly in google sheet. after this commit, the line returns have been removedd Task: 3618912 Part-of: #3566
robodoo
pushed a commit
that referenced
this pull request
Jan 30, 2024
Excel does not support unbound references like A3:3 or C3:C. This commit transforms them to A3:XX3 and C3:CXX where XX is the last column or row of the sheet. closes #3566 Task: 3618912 Signed-off-by: Lucas Lefèvre (lul) <[email protected]> Signed-off-by: Vincent Schippefilt (vsc) <[email protected]>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: : 3618912
review checklist
Forward-Port-Of: #3561
Forward-Port-Of: #3364