-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN-1541] Add delete action mutation #1609
Merged
alonkeyval
merged 432 commits into
odigos-io:new-ui
from
alonkeyval:gen-1541-delete-action-mutation
Oct 22, 2024
Merged
[GEN-1541] Add delete action mutation #1609
alonkeyval
merged 432 commits into
odigos-io:new-ui
from
alonkeyval:gen-1541-delete-action-mutation
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[GEN-1097] chore: setup redesign
[GEN-1099] chore: setup side menu
[GEN-1100] chore: setup choose source
[GEN-1503] feat: edit destination
…factor [GEN-1538] Refactor destinations types query
…roduct-rebranding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to the
DeleteAction
functionality in thefrontend/graph
package, adding support for anactionType
parameter. This enhancement allows for more specific handling of different action types during deletion.Key changes include:
GraphQL Schema and Resolvers
frontend/graph/schema.graphqls
: Updated thedeleteAction
mutation to include anactionType
parameter.frontend/graph/schema.resolvers.go
: Modified theDeleteAction
resolver to handle different action types based on theactionType
parameter.Generated Code
frontend/graph/generated.go
: Updated theDeleteAction
method signatures and complexity calculations to include theactionType
parameter. [1] [2] [3] [4] [5]Action Services
frontend/services/actions/addclusterinfo.go
: Added theDeleteAddClusterInfo
function to handle the deletion ofAddClusterInfo
actions.frontend/services/actions/addclusterinfo.go
: Importedapierrors
for error handling in the new deletion function.