forked from odigos-io/odigos
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN-1503] feat: edit destination #43
Merged
alonkeyval
merged 20 commits into
gen-1096-product-rebranding
from
gen-1503-edit-destination
Oct 20, 2024
Merged
[GEN-1503] feat: edit destination #43
alonkeyval
merged 20 commits into
gen-1096-product-rebranding
from
gen-1503-edit-destination
Oct 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to enhance the handling of destination types in the overview components and updates to dependencies. The most important changes include adding support for destination types in the
OverviewDataFlowContainer
andOverviewDrawer
, updating the import statements and type definitions, and a minor dependency update in thepackage.json
.Enhancements to overview components:
frontend/webapp/containers/main/overview/overview-data-flow/index.tsx
: AddedTYPE_DESTINATION
constant and logic to handle destination types in theOverviewDataFlowContainer
function. [1] [2]frontend/webapp/containers/main/overview/overview-drawer/index.tsx
: Updated import statements to includeActualDestination
type and refactored the image URI logic to use a newgetItemImageByType
function. [1] [2] [3]Updates to type definitions and imports:
frontend/webapp/reuseable-components/nodes-data-flow/builder.ts
: Updated import statements to includeActualDestination
and refactored the function signature ofbuildNodesAndEdges
to include destinations. [1] [2]frontend/webapp/store/useDrawerStore.tsx
: Updated type definitions to replaceDestination
withActualDestination
.Dependency updates:
frontend/webapp/package.json
: Updated the version of@apollo/experimental-nextjs-app-support
dependency.