[GEN-1100] chore: setup choose source #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…os-io#1373) Adding a separate Helm chart for CRDs. :exclamation: The charts are not strictly dependent to one another and need to be separately managed and installed. Meaning we need to document that both of those need to be updated and installed. Fair questions that might arise: **Why isn't CRD chart a declared dependency for `odigos`?** Helm merges dependent resources together with the ones from dependencies. We'd be exactly where we are right now if we did that. **Why not use the official `crd` support?** Helm really doesn't "support" CRDs. It's an opt-out feature of "we don't know how we want to do it so we don't for now". Resources declared as CRDs(different from declaring them under `templates`) are not updated. **How do other charts do it then?** All charts I've encountered(cert-manager, jaeger, contour) have CRDs under a flag and include them in the same chart as the rest of the resources **but then** do not depend on them in in the install. CRs are created either only by the user or later in the applications life-cycle. This doesn't work for us since we declare Odigos Config among resources in the application chart. That begs the question whether Odigos Config must be a CR at all or could it be a config map instead - we wouldn't get "type-checking" by k8s API but would gain some flexibility and could release our charts as one.
Co-authored-by: Tamir David <[email protected]>
Co-authored-by: Tamir David <[email protected]>
Co-authored-by: Tamir David <[email protected]>
* Use Pagination for large queries from Kubernetes API Server * When possible query only for metadata and not full objects (for example in the count objects in namespace logic)
…3 updates (odigos-io#1384) Bumps the k8s-dependencies group with 3 updates in the /odiglet directory: [k8s.io/api](https://github.com/kubernetes/api), [k8s.io/client-go](https://github.com/kubernetes/client-go) and [k8s.io/kubelet](https://github.com/kubernetes/kubelet). Updates `k8s.io/api` from 0.30.2 to 0.30.3 <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/kubernetes/api/commit/83bdab1c667f4708f1fe5cf9ce45af76505c12fd"><code>83bdab1</code></a> Update dependencies to v0.30.3 tag</li> <li>See full diff in <a href="https://github.com/kubernetes/api/compare/v0.30.2...v0.30.3">compare view</a></li> </ul> </details> <br /> Updates `k8s.io/client-go` from 0.30.2 to 0.30.3 <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/kubernetes/client-go/commit/ece8c00014596d814f9549b10c5f78cb7c022e82"><code>ece8c00</code></a> Update dependencies to v0.30.3 tag</li> <li>See full diff in <a href="https://github.com/kubernetes/client-go/compare/v0.30.2...v0.30.3">compare view</a></li> </ul> </details> <br /> Updates `k8s.io/kubelet` from 0.30.2 to 0.30.3 <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/kubernetes/kubelet/commit/71b03c0b35c8421757ed793c13fb9e6443c100de"><code>71b03c0</code></a> Update dependencies to v0.30.3 tag</li> <li>See full diff in <a href="https://github.com/kubernetes/kubelet/compare/v0.30.2...v0.30.3">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
create action button was disabled all the time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.