Avoid app to crash python agent #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirdavid1
force-pushed
the
avoid-app-to-crash-python-agent
branch
from
f06a9fa
to
40b6d28
Compare
RonFed
reviewed
Jul 22, 2024
| 'zipp', | ||
| 'urllib3', | ||
| 'uuid_extensions.uuid7', | ||
| 'typing_extensions', |
There was a problem hiding this comment.
Are these taken from requirements.txt? If so, maybe it is better to read them from the file or pass them as an argument
There was a problem hiding this comment.
Hey Ron,
This file is not exists in the runtime, also it is containing packages names that sometimes are different from the module name that i'm reloading.
e.g -> protobuf (pip install protobuf) but the module name is google.protobuf.
I thought about reloading all modules available in sys.modules but it can potentially take time
blumamir
approved these changes
Jul 22, 2024
tamirdavid1
force-pushed
the
avoid-app-to-crash-python-agent
branch
from
a28ea94
to
e3d9e9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.