-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: v9 #533
Merged
Merged
feat: v9 #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `createWebhooksApi()` has been removed. Use `new Webhooks()` instead
…Middleware` BREAKING CHANGE: `webhooks.middleware` has been removed. Use `createNodeMiddleware()` instead BREAKING CHANGE: `createMiddleware` has been removed. Use `createNodeMiddleware()` instead
BREAKING CHANGE: deprecated `path` option for `Webhooks` constructor has been removed. Use `createNodeMiddleware(webhooks, { path })` instead
BREAKING CHANGE: all usage of [`debug`](https://www.npmjs.com/package/debug) has been removed. Use the `log` option instead
BREAKING CHANGE: `sign` and `webhooks.sign` no default to `sha256` algorithm. In order to continue to use `sha1`, replace ```js sign(secret, payload) ``` with ```js sign({ secret, algorith: "sha1" }, payload) ```
BREAKING CHANGE: `webhooks.sign()` and `webhooks.verify()` are now asynchronous BREAKING CHANGE: static `sign` and `verify` methods are no longer exported. Use `@octokit/webhooks-methods` package instead
…idation checks. Adpat for async `webhooks.sign()`
🎉 This PR is included in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #518
fixes #477, fixes #515, fixes #476, fixes #475
Breaking changes
sign
algorithm forwebhooks.sign
is nowsha256
. Usewebhooks.sign({ algorithm: "sha1", secret }, payload)
to fall back tosha1
.sign
andverify
methods are no longer exported. Use@octokit/webhooks-methods
package insteadwebhooks.sign()
andwebhooks.verify()
are now asynchronousView rendered README.md
View rendered src/middleware-legacy/README.md
View rendered src/sign/README.md
View rendered src/verify/README.md