Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Recommend to use log client #476

Closed
oscard0m opened this issue Feb 18, 2021 · 2 comments · Fixed by #533
Closed

docs: Recommend to use log client #476

oscard0m opened this issue Feb 18, 2021 · 2 comments · Fixed by #533
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@oscard0m
Copy link
Member

I would not use it, it increases the bundle size, and I want @octokit/webhooks to work well in contraint environments such as browsers and Cloudflare Workers in future.

We can recommend to use it to users as we do in @octokit/core: https://github.com/octokit/core.js#logging

Originally posted by @gr2m in #201 (comment)

@wolfy1339
Copy link
Member

There is the log property in the options object arg of the Webhooks constructor.
It is documented in the README.
The middleware that was there at the time of this issue has been deprecated, and will be removed in v9

@wolfy1339 wolfy1339 mentioned this issue Apr 10, 2021
3 tasks
@gr2m gr2m mentioned this issue Apr 14, 2021
@gr2m gr2m closed this as completed in #533 Apr 14, 2021
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 9.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants