feat: v9 #518
Closed
feat: v9 #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `createWebhooksApi()` has been removed. Use `new Webhooks()` instead
…Middleware` BREAKING CHANGE: `webhooks.middleware` has been removed. Use `createNodeMiddleware()` instead BREAKING CHANGE: `createMiddleware` has been removed. Use `createNodeMiddleware()` instead
BREAKING CHANGE: deprecated `path` option for `Webhooks` constructor has been removed. Use `createNodeMiddleware(webhooks, { path })` instead
BREAKING CHANGE: all usage of [`debug`](https://www.npmjs.com/package/debug) has been removed. Use the `log` option instead
|
v9 beta.1 release: https://github.com/octokit/webhooks.js/releases/tag/v9.0.0-beta.1 |
BREAKING CHANGE: `sign` and `webhooks.sign` no default to `sha256` algorithm. In order to continue to use `sha1`, replace
```js
sign(secret, payload)
```
with
```js
sign({ secret, algorith: "sha1" }, payload)
```
|
v9 beta.2 release: https://github.com/octokit/webhooks.js/releases/tag/v9.0.0-beta.2 |
BREAKING CHANGE: `webhooks.sign()` and `webhooks.verify()` are now asynchronous BREAKING CHANGE: static `sign` and `verify` methods are no longer exported. Use `@octokit/webhooks-methods` package instead
|
This is ready to be merged. I've pushed a @octokit/maintainers anyone of you would like to give this a review? |
|
Fixes #476 by removing the deprecated middleware |
|
v9 beta.4 release: https://github.com/octokit/webhooks.js/releases/tag/v9.0.0-beta.4 I tested it in the browser console with pkg = await import("https://cdn.skypack.dev/@octokit/[email protected]")
const webhooks = new pkg.Webhooks({
secret: "secret"
})
await webhooks.sign("payload")and it works great |
|
Unless there are any objects, I'd like to release this on Tuesday |
This was referenced Apr 11, 2021
Merged
Merged
|
🎉 This issue has been resolved in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
semantic-releaseI've pushed a
beta-rebasedbranch which resolves the conflicts.fixes #477, fixes #515, fixes #476, fixes #475
Breaking changes
signalgorithm forwebhooks.signis nowsha256. Usewebhooks.sign({ algorithm: "sha1", secret }, payload)to fall back tosha1.signandverifymethods are no longer exported. Use@octokit/webhooks-methodspackage insteadwebhooks.sign()andwebhooks.verify()are now asynchronousTODOs
sha256webhooks.signandwebhooks.verifyasync, for compatibility with Browsers and DenosignandverifymethodsView rendered src/middleware-legacy/README.md