This repository has been archived by the owner on Apr 21, 2022. It is now read-only.
Allow custom "acl" key in oclif.update.s3 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the developer to specify the ACL that their S3 bucket uses, overriding the default of "public-read" which may not be available on some internally-used S3 buckets.
|
Thanks for the contribution! Before we can merge this, we need @ryanwilsonperkin to sign the Salesforce.com Contributor License Agreement. |
|
I believe tests won't pass because I'm not a member of the org: #76 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm interested in contributing a new feature: a custom
aclkey to be used in thepackage.jsonfile that would allow the developer to specify a custom AWS ACL to use when uploading versions of their CLI.We're maintaining a CLI built on oclif that's only intended for private use within the org. We achieve this by publishing it to an S3 bucket that has an ACL configured to only allow reads from private IP addresses. This requires that when we upload objects to the bucket that we specify an ACL of "private'. The
publishcommands were hardcoding an ACL of "public-read" but this would allow them to be more flexible.