Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

Allow acl in S3 interface #65

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Conversation

ryanwilsonperkin
Copy link
Contributor

Companion PR to oclif/dev-cli#79

Exposes acl property in the S3 interface that can be used to specify a custom ACL when uploading the packed CLI.

@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #65 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   69.62%   69.33%   -0.29%     
==========================================
  Files           7        7              
  Lines         428      424       -4     
  Branches      116      117       +1     
==========================================
- Hits          298      294       -4     
  Misses         83       83              
  Partials       47       47
Impacted Files Coverage Δ
src/debug.ts 40% <0%> (-17.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3086696...1aaa312. Read the comment docs.

@ryanwilsonperkin
Copy link
Contributor Author

Having some trouble understanding the issue in codecov/project - it tells me that the base has not uploaded a report yet, but that could be that I just don't have permission to see it.

@jdx jdx merged commit bd2e633 into oclif:master Dec 18, 2018
@ryanwilsonperkin ryanwilsonperkin deleted the allow-custom-s3-acl branch December 18, 2018 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants