Skip to content
This repository has been archived by the owner on Apr 21, 2022. It is now read-only.

Allow custom "acl" key in oclif.update.s3 #79

Merged
merged 1 commit into from
Dec 18, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/commands/publish/deb.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export default class PublishDeb extends Command {
if (!await qq.exists(dist('Release'))) this.error('run "oclif-dev pack:deb" before publishing')
const S3Options = {
Bucket: s3Config.bucket!,
ACL: 'public-read',
ACL: s3Config.acl || 'public-read',
}

const remoteBase = buildConfig.channel === 'stable' ? 'apt' : `channels/${buildConfig.channel}/apt`
Expand Down
2 changes: 1 addition & 1 deletion src/commands/publish/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export default class Publish extends Command {
if (!await qq.exists(dist(config.s3Key('versioned', {ext: '.tar.gz'})))) this.error('run "oclif-dev pack" before publishing')
const S3Options = {
Bucket: s3Config.bucket!,
ACL: 'public-read',
ACL: s3Config.acl || 'public-read',
}
// for (let target of targets) await this.uploadNodeBinary(target)
const ManifestS3Options = {...S3Options, CacheControl: 'max-age=86400', ContentType: 'application/json'}
Expand Down
2 changes: 1 addition & 1 deletion src/commands/publish/macos.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default class PublishMacos extends Command {
const {s3Config, version, config} = buildConfig
const S3Options = {
Bucket: s3Config.bucket!,
ACL: 'public-read',
ACL: s3Config.acl || 'public-read',
}

let root = buildConfig.channel === 'stable' ? '' : `channels/${buildConfig.channel}/`
Expand Down
2 changes: 1 addition & 1 deletion src/commands/publish/win.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default class PublishWin extends Command {
const {s3Config, version, config} = buildConfig
const S3Options = {
Bucket: s3Config.bucket!,
ACL: 'public-read',
ACL: s3Config.acl || 'public-read',
}

let root = buildConfig.channel === 'stable' ? '' : `channels/${buildConfig.channel}/`
Expand Down