[3.15] backport #10442 #10449
Merged
[3.15] backport #10442 #10449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
emillon
commented
Apr 22, 2024
emillon
commented
- refactor: evaluate directory targets enabled_if in parallel map (refactor: evaluate directory targets enabled_if in parallel map #10402)
- fix: lazier directory target extraction (fix: lazier directory target extraction #10442)
…l#10402) Signed-off-by: Rudi Grinberg <[email protected]>
If no directory targets are defined, then do not evaluate enabled_if Signed-off-by: Rudi Grinberg <[email protected]>
|
I had to pick the refactor which changes some error messages but that looks safe enough to me. |
Leonidas-from-XIV
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.