refactor: evaluate directory targets enabled_if in parallel map #10402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
ps/rr/refactor__evaluate_directory_targets_enabled_if_in_parallel_map
branch
2 times, most recently
from
3510de4
to
539b010
Compare
anmonteiro
reviewed
Apr 7, 2024
| @@ -1,20 +1,18 @@ | |||
| We try to build the documentation but there will be a clash between the | |||
| directory targets. Notice how the tex one fails before html one. | |||
There was a problem hiding this comment.
Notice how the tex one fails before html one.
This is no longer true?
Will this test be deterministic with parallel_map?
anmonteiro
approved these changes
Apr 7, 2024
rgrinberg
force-pushed
the
ps/rr/refactor__evaluate_directory_targets_enabled_if_in_parallel_map
branch
2 times, most recently
from
a3b70d6
to
999db7b
Compare
Signed-off-by: Rudi Grinberg <[email protected]> <!-- ps-id: 6488fef7-3f8d-436f-a876-17f6615d6e3e -->
rgrinberg
force-pushed
the
ps/rr/refactor__evaluate_directory_targets_enabled_if_in_parallel_map
branch
from
999db7b
to
91ed5f6
Compare
rgrinberg
deleted the
ps/rr/refactor__evaluate_directory_targets_enabled_if_in_parallel_map
branch
emillon
pushed a commit
to emillon/dune
that referenced
this pull request
Apr 22, 2024
…l#10402) Signed-off-by: Rudi Grinberg <[email protected]>
emillon
pushed a commit
to emillon/dune
that referenced
this pull request
Apr 22, 2024
…l#10402) Signed-off-by: Rudi Grinberg <[email protected]>
emillon
added a commit
that referenced
this pull request
Apr 23, 2024
* refactor: evaluate directory targets enabled_if in parallel map (#10402) Signed-off-by: Rudi Grinberg <[email protected]> * fix: lazier directory target extraction (#10442) If no directory targets are defined, then do not evaluate enabled_if Signed-off-by: Rudi Grinberg <[email protected]> --------- Signed-off-by: Rudi Grinberg <[email protected]> Co-authored-by: Rudi Grinberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rudi Grinberg [email protected]