fix: lazier directory target extraction #10442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
reviewed
Apr 18, 2024
rgrinberg
force-pushed
the
ps/rr/fix__lazier_directory_target_extraction
branch
from
f269a9c
to
95e4606
Compare
anmonteiro
approved these changes
Apr 18, 2024
If no directory targets are defined, then do not evaluate enabled_if Signed-off-by: Rudi Grinberg <[email protected]> <!-- ps-id: cf8418bc-d40c-4f48-ac10-f4f855944250 -->
rgrinberg
force-pushed
the
ps/rr/fix__lazier_directory_target_extraction
branch
from
95e4606
to
1a4631b
Compare
This was referenced Apr 22, 2024
emillon
pushed a commit
to emillon/dune
that referenced
this pull request
Apr 22, 2024
If no directory targets are defined, then do not evaluate enabled_if Signed-off-by: Rudi Grinberg <[email protected]>
emillon
pushed a commit
to emillon/dune
that referenced
this pull request
Apr 22, 2024
If no directory targets are defined, then do not evaluate enabled_if Signed-off-by: Rudi Grinberg <[email protected]>
emillon
added a commit
that referenced
this pull request
Apr 23, 2024
* refactor: evaluate directory targets enabled_if in parallel map (#10402) Signed-off-by: Rudi Grinberg <[email protected]> * fix: lazier directory target extraction (#10442) If no directory targets are defined, then do not evaluate enabled_if Signed-off-by: Rudi Grinberg <[email protected]> --------- Signed-off-by: Rudi Grinberg <[email protected]> Co-authored-by: Rudi Grinberg <[email protected]>
Merged
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Apr 23, 2024
CHANGES: ### Fixed - If no directory targets are defined, then do not evaluate `enabled_if` (ocaml/dune#10442, @rgrinberg) - Fix a bug where Coq projects were being rebuilt from scratch each time the dependency graph changed. (ocaml/dune#10446, fixes ocaml/dune#10149, @Alizter)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no directory targets are defined, then do not evaluate enabled_if
might fix the bug reported by @anmonteiro
cc @gridbugs