Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 4.12 #107

Merged
merged 14 commits into from
Oct 21, 2020
Merged

Support 4.12 #107

merged 14 commits into from
Oct 21, 2020

Conversation

ceastlund
Copy link
Collaborator

Added support for 4.12 compiler to ocaml-migrate-parsetree. Updated instructions in README for adding new versions.

@ceastlund ceastlund requested review from a user and NathanReb September 23, 2020 21:41
hhugo
hhugo reviewed Sep 23, 2020
View reviewed changes
src/ast_412.ml Outdated Show resolved Hide resolved
@kit-ty-kate kit-ty-kate mentioned this pull request Oct 6, 2020
Merged
@NathanReb
Copy link
Collaborator

Following #106 we'll need to upgrade the upper bound!

@hhugo
Copy link
Contributor

hhugo commented Oct 7, 2020

The build fails with old version of the compiler

characters 9-19:
# Error: Unbound module Option

@hhugo hhugo mentioned this pull request Oct 8, 2020
Merged
@kit-ty-kate kit-ty-kate mentioned this pull request Oct 19, 2020
Merged
@ceastlund
allow 4.12 compiler
13d9077 
Signed-off-by: Carl Eastlund <[email protected]>
@ceastlund
first two steps in adding a new version
2006329 
Signed-off-by: Carl Eastlund <[email protected]>
@ceastlund
cinaps promotion for new parsetree
d37c144 
Signed-off-by: Carl Eastlund <[email protected]>
@ceastlund
add injectivity type
55e58f8 
Signed-off-by: Carl Eastlund <[email protected]>
@ceastlund
copy magic numbers
6c6dde5 
Signed-off-by: Carl Eastlund <[email protected]>
@ceastlund
update readme
2f72b9f 
Signed-off-by: Carl Eastlund <[email protected]>
@ceastlund
generate new conversions
58a1c45 
Signed-off-by: Carl Eastlund <[email protected]>
@ceastlund
updated conversion functions
e17c35f 
Signed-off-by: Carl Eastlund <[email protected]>
@ceastlund
restore compatibility with older compiler versions
058ff45 
Signed-off-by: Carl Eastlund <[email protected]>
@ceastlund
simplify some trivial identity transformations
a238ef2 
Signed-off-by: Carl Eastlund <[email protected]>
@ceastlund
bump magic numbers
b45c85d 
Signed-off-by: Carl Eastlund <[email protected]>
NathanReb
NathanReb reviewed Oct 20, 2020
View reviewed changes
Copy link
Collaborator

@NathanReb NathanReb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to upgrade the constraint in the opam file from < "4.12" to < "4.13" but besides that it looks good to me!

@ceastlund can you confirm once the constraint is updated this is good to go? I'd like to cut a release ASAP!

@NathanReb
Copy link
Collaborator

Hmm actually it seems this breaks the compat with ocaml < 4.07, see the CI failure:

File "src/migrate_411_412.ml", line 1194, characters 20-42:
Error: Unbound module Stdlib
Hint: Did you mean Stdlib0?

NathanReb
NathanReb reviewed Oct 20, 2020
View reviewed changes
src/migrate_411_412.ml Show resolved Hide resolved
src/migrate_411_412.ml Outdated Show resolved Hide resolved
@ceastlund
Copy link
Collaborator Author

Hmm actually it seems this breaks the compat with ocaml < 4.07, see the CI failure:

File "src/migrate_411_412.ml", line 1194, characters 20-42:
Error: Unbound module Stdlib
Hint: Did you mean Stdlib0?

I don't get this error with, say, 4.04 currently. It should be fixed as of 058ff45. What compiler version and what git revision are you using that still gets that error?

@ceastlund
Copy link
Collaborator Author

We need to upgrade the constraint in the opam file from < "4.12" to < "4.13" but besides that it looks good to me!

@ceastlund can you confirm once the constraint is updated this is good to go? I'd like to cut a release ASAP!

As far as I know this is good to go, but of course I've missed things other people had to point out. If it looks good to you now, it also looks good to me.

@NathanReb
Copy link
Collaborator

I don't get this error with, say, 4.04 currently. It should be fixed as of 058ff45. What compiler version and what git revision are you using that still gets that error?

That was in the CI but it's fixed now!

NathanReb
NathanReb approved these changes Oct 21, 2020
View reviewed changes
Copy link
Collaborator

@NathanReb NathanReb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@NathanReb NathanReb merged commit c85866f into ocaml-ppx:master Oct 21, 2020
NathanReb added a commit to NathanReb/opam-repository that referenced this pull request Oct 22, 2020
@NathanReb
[new release] ocaml-migrate-parsetree (2.1.0)
d7fca09 
CHANGES:

- Add support for 4.12 (ocaml-ppx/ocaml-migrate-parsetree#107, @ceastlund)
@NathanReb NathanReb mentioned this pull request Oct 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit-ty-kate kit-ty-kate kit-ty-kate left review comments

@hhugo hhugo hhugo left review comments

@NathanReb NathanReb NathanReb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ceastlund @NathanReb @hhugo @kit-ty-kate